Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove needless lifetimes (std) #62123

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Remove needless lifetimes (std) #62123

merged 2 commits into from
Jul 5, 2019

Conversation

jeremystucki
Copy link
Contributor

Split from #62039

@bors
Copy link
Contributor

bors commented Jun 29, 2019

☔ The latest upstream changes (presumably #62226) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 29, 2019
@jeremystucki jeremystucki force-pushed the needless_lifetimes_std branch from 8b96559 to 47ea8ae Compare July 1, 2019 10:15
@jeremystucki
Copy link
Contributor Author

r? @steveklabnik

@steveklabnik
Copy link
Member

This should be reviewed by someone from @rust-lang/libs according to @eddyb over in the other PR.

@alexcrichton
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 3, 2019

📌 Commit 47ea8ae has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019
@Centril
Rollup merge of rust-lang#62123 - jeremystucki:needless_lifetimes_std…
dad3222 
…, r=alexcrichton

 Remove needless lifetimes (std)

Split from rust-lang#62039
@Centril Centril mentioned this pull request Jul 3, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019
@Centril
Rollup merge of rust-lang#62123 - jeremystucki:needless_lifetimes_std…
8d3cc45 
…, r=alexcrichton

 Remove needless lifetimes (std)

Split from rust-lang#62039
@Centril Centril mentioned this pull request Jul 3, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Jul 3, 2019

Failed in #62352 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2019
@jeremystucki @Centril
Add missing lifetime specifier
fc67e57 
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
@jeremystucki
Copy link
Contributor Author

r? @alexcrichton

@Centril
Copy link
Contributor

Centril commented Jul 4, 2019

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 4, 2019

📌 Commit fc67e57 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2019
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62123 - jeremystucki:needless_lifetimes_std…
73fa329 
…, r=alexcrichton

 Remove needless lifetimes (std)

Split from rust-lang#62039
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 4, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62123 - jeremystucki:needless_lifetimes_std…
65826d2 
…, r=alexcrichton

 Remove needless lifetimes (std)

Split from rust-lang#62039
@Centril Centril mentioned this pull request Jul 5, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62123 - jeremystucki:needless_lifetimes_std…
0f92eb8 
…, r=alexcrichton

 Remove needless lifetimes (std)

Split from rust-lang#62039
@Centril Centril mentioned this pull request Jul 5, 2019
Merged
bors added a commit that referenced this pull request Jul 5, 2019
@bors
Auto merge of #62407 - Centril:rollup-g0zmff7, r=Centril
853f300 
Rollup of 10 pull requests

Successful merges:

 - #62123 ( Remove needless lifetimes (std))
 - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.)
 - #62169 (Derive which queries to save using the proc macro)
 - #62238 (Fix code block information icon position)
 - #62292 (Move `async || ...` closures into `#![feature(async_closure)]`)
 - #62323 (Clarify unaligned fields in ptr::{read,write}_unaligned)
 - #62324 (Reduce reliance on `await!(...)` macro)
 - #62371 (Add tracking issue for Box::into_pin)
 - #62383 (Improve error span for async type inference error)
 - #62388 (Break out of the correct number of scopes in loops)

Failed merges:

r? @ghost
@bors bors merged commit fc67e57 into rust-lang:master Jul 5, 2019
@jeremystucki jeremystucki deleted the needless_lifetimes_std branch July 6, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeremystucki @bors @steveklabnik @alexcrichton @Centril