-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up tidy #62037
Speed up tidy #62037
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
a0e1e9e
to
2a0d1cc
Compare
@bors r+ |
📌 Commit 2a0d1cc4182d6cb3433175f3b8ace42e3d99dec3 has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
It's more efficient than the fs::read_dir API
2a0d1cc
to
777951c
Compare
@bors r=eddyb |
📌 Commit 777951c has been approved by |
Speed up tidy master: Time (mean ± σ): 3.478 s ± 0.033 s [User: 3.298 s, System: 0.178 s] Range (min … max): 3.425 s … 3.525 s 10 runs This PR: Time (mean ± σ): 1.098 s ± 0.006 s [User: 783.7 ms, System: 310.2 ms] Range (min … max): 1.092 s … 1.113 s 10 runs Alleviates rust-lang#59884. For the most part each commit stands on its own. Timings are on warm filesystem cache. r? @eddyb
Rollup of 5 pull requests Successful merges: - #61778 (compiletest: Introduce `// {check,build,run}-pass` pass modes) - #62037 (Speed up tidy) - #62052 (submodules: Update clippy from 5a11ed7 to c5d1ecd) - #62070 (Run rustfmt on some libsyntax files) - #62075 (Remove `ast::Guard`) Failed merges: r? @ghost
Speed up tidy master: Time (mean ± σ): 3.478 s ± 0.033 s [User: 3.298 s, System: 0.178 s] Range (min … max): 3.425 s … 3.525 s 10 runs This PR: Time (mean ± σ): 1.098 s ± 0.006 s [User: 783.7 ms, System: 310.2 ms] Range (min … max): 1.092 s … 1.113 s 10 runs Alleviates #59884. For the most part each commit stands on its own. Timings are on warm filesystem cache. r? @eddyb
☀️ Test successful - checks-travis, status-appveyor |
master:
Time (mean ± σ): 3.478 s ± 0.033 s [User: 3.298 s, System: 0.178 s]
Range (min … max): 3.425 s … 3.525 s 10 runs
This PR:
Time (mean ± σ): 1.098 s ± 0.006 s [User: 783.7 ms, System: 310.2 ms]
Range (min … max): 1.092 s … 1.113 s 10 runs
Alleviates #59884. For the most part each commit stands on its own. Timings are on warm filesystem cache.
r? @eddyb