Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize exact_size_is_empty feature #61366

Closed
wants to merge 1 commit into from
Closed

Stabilize exact_size_is_empty feature #61366

wants to merge 1 commit into from

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented May 30, 2019

FCP done in #35428 (comment)

Closes #35428

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2019
@tesuji

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 30, 2019
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label May 30, 2019
@jonas-schievink jonas-schievink added this to the 1.37 milestone May 30, 2019
@Centril
Copy link
Contributor

Centril commented May 30, 2019

r? @SimonSapin

cc @rust-lang/libs
cc @scottmcm -- you had concerns?

@rust-highfive rust-highfive assigned SimonSapin and unassigned Centril May 30, 2019
@scottmcm
Copy link
Member

scottmcm commented May 31, 2019 •
edited
Loading

Note that the PR referenced in the OP here is over two years old, and is_empty was explicitly removed from stabilization due to concerns raised (#35428 (comment)), so I don't think this PR is a fait accompli.

I continue to feel that .is_empty() is too useful to be limited to just ExactSizeIterators.

@SimonSapin
Copy link
Contributor

At a risk of rehashing the previous thread, please expand on what you would prefer instead. If it should not be limited to that, then what should it be? That plus methods on other existing trait(s) and/or inherent methods on some types? A dedicated trait? Why? Would a dedicated trait be used in a bound in a generic context?

Having someone champion and argue for a counter-proposal could be a way to unblock this.

@Dylan-DPC-zz Dylan-DPC-zz added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2019
@Centril Centril modified the milestones: 1.37, 1.38 Jul 2, 2019
@scottmcm scottmcm mentioned this pull request Jul 8, 2019
Open
@tesuji tesuji force-pushed the stabilize-exact_size_is_empty branch from 54699aa to 2974a70 Compare July 9, 2019 08:16
@Centril Centril modified the milestones: 1.38, 1.39 Aug 13, 2019
@Centril Centril modified the milestones: 1.39, 1.40 Sep 26, 2019
@tesuji tesuji force-pushed the stabilize-exact_size_is_empty branch 2 times, most recently from 6dae8d4 to f478159 Compare September 28, 2019 16:57
@bors
Copy link
Contributor

bors commented Oct 19, 2019

☔ The latest upstream changes (presumably #65588) made this pull request unmergeable. Please resolve the merge conflicts.

@tesuji tesuji force-pushed the stabilize-exact_size_is_empty branch from f478159 to f938d3b Compare October 19, 2019 09:24
@Mark-Simulacrum
Copy link
Member

I'm going to close this PR as it seems like discussion can happen on the issue until we reach a conclusion (#35428). Thanks for the PR, though!

@Mark-Simulacrum Mark-Simulacrum added S-blocked-closed and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 24, 2019
@Centril Centril removed this from the 1.40 milestone Nov 7, 2019
@jyn514 jyn514 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-blocked-closed labels Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add is_empty function to ExactSizeIterator