Do not fail on child without DefId #60982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
No regression test? |
|
Sure; it would be good to minimize it if possible tho... :) |
|
cc @rust-lang/compiler for visibility |
|
r=me, the fix looks correct, but a test with minimized reproduction would be nice |
petrochenkov
added
S-waiting-on-author
|
I won't be having the time to make a repro case. I will merge this PR and leave the report open with |
|
@bors r=petrochenkov rollup |
|
📌 Commit d320c7c has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 21, 2019
Do not fail on child without DefId Addresses rust-lang#60976, leaving open to come up with a repro case.
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 21, 2019
Do not fail on child without DefId Addresses rust-lang#60976, leaving open to come up with a repro case.
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 22, 2019
Do not fail on child without DefId Addresses rust-lang#60976, leaving open to come up with a repro case.
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 22, 2019
Do not fail on child without DefId Addresses rust-lang#60976, leaving open to come up with a repro case.
bors
added a commit
that referenced
this pull request
May 22, 2019
Rollup of 10 pull requests Successful merges: - #59742 (Move `edition` outside the hygiene lock and avoid accessing it) - #60581 (convert custom try macro to `?`) - #60963 (Update boxed::Box docs on memory layout) - #60973 (Avoid symbol interning in `file_metadata`.) - #60982 (Do not fail on child without DefId) - #60991 (LocalDecl push returns Local len) - #60995 (Add stream_to_parser_with_base_dir) - #60998 (static_assert: make use of anonymous constants) - #61003 (Remove impls for `InternedString`/string equality.) - #61006 (adjust deprecation date of mem::uninitialized) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #60976, leaving open to come up with a repro case.