Do not put noalias annotations by default #54639

nagisa · 2018-09-28T14:49:31Z

This will be re-enabled sooner or later depending on results of further
investigation.

Fixes #54462

Beta backport is: #54640

r? @nikomatsakis

eddyb · 2018-09-28T15:21:55Z

@bors r+

bors · 2018-09-28T15:21:56Z

📌 Commit 24964b18b4b13100df04c46bb792b592a0dbf137 has been approved by eddyb

uberjay · 2018-09-28T15:49:57Z

src/librustc_codegen_llvm/type_of.rs

+                        // in conjunction with unwinding, but later versions didn’t seem to have
+                        // said issues. See issue #31681.
+                        //
+                        // Alas, later on we encountered a case where nomangle would generate wrong


nomangle -> noalias?

Ew, that’s embarrassing.

nagisa · 2018-09-28T15:54:38Z

@bors r=eddyb

bors · 2018-09-28T15:54:38Z

📌 Commit 8a261a873fe00b9e7c197f5462a163be2562b0fc has been approved by eddyb

kennytm · 2018-09-29T08:39:28Z

@bors r-

The codegen test codegen\function-arguments.rs failed on x86_64-pc-windows-msvc. Error log: #54660 (comment)

C:\projects\rust\src/test\codegen\function-arguments.rs:56:11: error: CHECK: expected string not found in input
// CHECK: @mutable_unsafe_borrow(i16* noalias dereferenceable(2) %arg0)
          ^
C:\projects\rust\build\x86_64-pc-windows-msvc\test\codegen\function-arguments\function-arguments.ll:272:59: note: scanning from here
define void @unsafe_borrow(i16* dereferenceable(2) %arg0) unnamed_addr #0 {
                                                          ^
C:\projects\rust\build\x86_64-pc-windows-msvc\test\codegen\function-arguments\function-arguments.ll:278:5: note: possible intended match here
define void @mutable_unsafe_borrow(i16* dereferenceable(2) %arg0) unnamed_addr #0 {
    ^

This will be re-enabled sooner or later depending on results of further investigation. Fixes rust-lang#54462

nagisa · 2018-09-29T10:36:10Z

@bors r=eddyb

bors · 2018-09-29T10:36:11Z

📌 Commit 9c62193 has been approved by eddyb

bors · 2018-09-30T06:44:20Z

⌛ Testing commit 9c62193 with merge 8c1d5e5...

@nikomatsakis

Do not put noalias annotations by default This will be re-enabled sooner or later depending on results of further investigation. Fixes #54462 Beta backport is: #54640 r? @nikomatsakis

bors · 2018-09-30T09:22:28Z

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 8c1d5e5 to master...

@nikomatsakis

[beta] Do not put noalias annotations by default This will be re-enabled sooner or later depending on results of further investigation. This is a backport of #54639 r? @nikomatsakis

nagisa · 2018-10-02T16:21:18Z

Beta backport for this has landed as well, so just marking as beta-accepted.

pnkfelix · 2018-10-04T14:56:31Z

We discussed this (for a perhaps surprisingly long time) at the T-compiler meeting.

No one objects to the idea of backporting this PR to stable in terms of the benefit of this change and the risk involved.

There was some debate about whether a point release is justifiable for this particular bug.

Namely, it was suggested that point releases should be reserved for:

security fixes
accidental stabilizations
fixes to new (and "severe") regressions.

But there was enough debate about whether that is the policy to then lead us to say that we should resolve that question separately from the approval process for this PR.

So, tagging as stable-accepted.

@Mark-Simulacrum

1.29.2 stable point release This point release includes a backport of #54639 (a miscompilation) and the fix for #54206 (rls missing on windows-gnu). It also backports a release notes fix (#54150). The target date for the release is Thursday 11th. r? @Mark-Simulacrum cc @rust-lang/core @rust-lang/release

It has been fully disabled by default since rust-lang#54639.

…=rkruppe Update the documented default of -Z mutable-noalias It has been fully disabled by default since rust-lang#54639.

nagisa added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Sep 28, 2018

nagisa assigned nikomatsakis Sep 28, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2018

nagisa mentioned this pull request Sep 28, 2018

[beta] Do not put noalias annotations by default #54640

Merged

nagisa force-pushed the lets-alias-for-now branch from 56358ca to 24964b1 Compare September 28, 2018 15:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2018

uberjay reviewed Sep 28, 2018

View reviewed changes

nagisa force-pushed the lets-alias-for-now branch from 24964b1 to 8a261a8 Compare September 28, 2018 15:54

kennytm mentioned this pull request Sep 29, 2018

Rollup of 8 pull requests #54660

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 29, 2018

Do not put noalias annotations by default

9c62193

This will be re-enabled sooner or later depending on results of further investigation. Fixes rust-lang#54462

nagisa force-pushed the lets-alias-for-now branch from 8a261a8 to 9c62193 Compare September 29, 2018 10:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 29, 2018

bors merged commit 9c62193 into rust-lang:master Sep 30, 2018

nagisa added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Oct 2, 2018

pietroalbini mentioned this pull request Oct 4, 2018

1.29.2 stable point release #54808

Merged

pnkfelix added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Oct 4, 2018

pietroalbini removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Oct 6, 2018

bstrie mentioned this pull request Oct 6, 2018

Enable noalias annotations #54878

Closed

hanna-kruppe mentioned this pull request Aug 22, 2019

Stabilize async_await in Rust 1.39.0 #63209

Merged

9 tasks

cuviper added a commit to cuviper/rust that referenced this pull request Oct 4, 2019

Update the documented default of -Z mutable-noalias

8bb5c12

It has been fully disabled by default since rust-lang#54639.

cuviper mentioned this pull request Oct 4, 2019

Update the documented default of -Z mutable-noalias #65118

Merged

tmandry added a commit to tmandry/rust that referenced this pull request Oct 5, 2019

Rollup merge of rust-lang#65118 - cuviper:Zmutable-noalias-default, r…

0fb7740

…=rkruppe Update the documented default of -Z mutable-noalias It has been fully disabled by default since rust-lang#54639.

tmandry added a commit to tmandry/rust that referenced this pull request Oct 6, 2019

Rollup merge of rust-lang#65118 - cuviper:Zmutable-noalias-default, r…

a1eac17

…=rkruppe Update the documented default of -Z mutable-noalias It has been fully disabled by default since rust-lang#54639.

tspiteri mentioned this pull request Oct 12, 2019

Unnecessary comparison and conditional branch #65333

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not put noalias annotations by default #54639

Do not put noalias annotations by default #54639

nagisa commented Sep 28, 2018 •

edited

Loading

eddyb commented Sep 28, 2018

bors commented Sep 28, 2018

uberjay Sep 28, 2018

nagisa Sep 28, 2018

nagisa commented Sep 28, 2018

bors commented Sep 28, 2018

kennytm commented Sep 29, 2018

nagisa commented Sep 29, 2018

bors commented Sep 29, 2018

bors commented Sep 30, 2018

bors commented Sep 30, 2018

nagisa commented Oct 2, 2018

pnkfelix commented Oct 4, 2018

Do not put noalias annotations by default #54639

Do not put noalias annotations by default #54639

Conversation

nagisa commented Sep 28, 2018 • edited Loading

eddyb commented Sep 28, 2018

bors commented Sep 28, 2018

uberjay Sep 28, 2018

Choose a reason for hiding this comment

nagisa Sep 28, 2018

Choose a reason for hiding this comment

nagisa commented Sep 28, 2018

bors commented Sep 28, 2018

kennytm commented Sep 29, 2018

nagisa commented Sep 29, 2018

bors commented Sep 29, 2018

bors commented Sep 30, 2018

bors commented Sep 30, 2018

nagisa commented Oct 2, 2018

pnkfelix commented Oct 4, 2018

nagisa commented Sep 28, 2018 •

edited

Loading