-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate src/test/ui/run-pass/*
back to src/test/run-pass/
.
#54530
Migrate src/test/ui/run-pass/*
back to src/test/run-pass/
.
#54530
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
r=me with green tests |
ha ha ha that was not expected |
Ah, I see, my issue is this: rust/src/tools/compiletest/src/runtest.rs Lines 1342 to 1352 in ae36663
In other words, we have a blanket In yet more other words, what happened was:
Okay. That's the explanation. Now my fix is just to add the necessary lint allows, I think. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The reason I’m missing cases like this is that i hit linker errors on four tests during the non-compare-mode phase, so once I get things down to those tests I have to choose between adding temp I will at least try to make sure I have a ticket filed for these specific linker errors, which seem to come from some combination of codegen-units, linktime optimization, and/or incremental compilation (via
|
☔ The latest upstream changes (presumably #54497) made this pull request unmergeable. Please resolve the merge conflicts. |
…mpiling with clean stderr again. Most were added mechanically.
53987b4
to
8d86800
Compare
@bors r=alexcrichton |
📌 Commit 8d86800 has been approved by |
⌛ Testing commit 8d86800 with merge b1099d14e836b9c39b074384fb39b4734ef25052... |
💔 Test failed - status-appveyor |
Two failures on Windows due to unexpected warnings.
|
src/test/ui/run-pass/*
back to src/test/run-pass/
.src/test/ui/run-pass/*
back to src/test/run-pass/
.
(marking as |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
src/test/ui/run-pass/*
back to src/test/run-pass/
.src/test/ui/run-pass/*
back to src/test/run-pass/
.
⌛ Testing commit fe4d8d8 with merge ceba374e7180b6f124d34e21ef3910a6bf1416ee... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r- retry ↑ |
src/test/ui/run-pass/*
back to src/test/run-pass/
.src/test/ui/run-pass/*
back to src/test/run-pass/
.
847caf6
to
649b20e
Compare
src/test/ui/run-pass/*
back to src/test/run-pass/
.src/test/ui/run-pass/*
back to src/test/run-pass/
.
💡 This pull request was already approved, no need to approve it again.
|
☀️ Test successful - status-appveyor, status-travis |
Moves all the tests from
src/test/ui/run-pass/**
back tosrc/test/run-pass/
.This should have no impact on our overall testing completeness due to PR #54223
Fix #54047