Add a implementation of `From` for converting `&'a Option<T>` into `Option<&'a T>` #53218

weiznich · 2018-08-09T09:40:07Z

I'm not sure if any annotations regarding the stabilization are needed or in general what's the correct process of adding such an impl.

cc @sgrif (We have talked about this)

`Option<&'a T>`

rust-highfive · 2018-08-09T09:40:10Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

kennytm · 2018-08-09T09:47:08Z

src/libcore/option.rs

@@ -1064,6 +1064,12 @@ impl<T> From<T> for Option<T> {
    }
 }

+impl<'a, T> From<&'a Option<T>> for Option<&'a T> {


I'm not sure if any annotations regarding the stabilization are needed

Yes this needs to be #[stable(feature = "option_ref_from_ref_option", since = "1.30.0")]. (The feature name can be anything unique). This is going to be insta-stable.

clarfonthey · 2018-08-09T14:46:17Z

Could you add a mutable version too? Awesome job!

… T>'

KodrAus · 2018-08-12T01:45:05Z

Thanks @weiznich! I think we'll need to do a crater run for this, because new impl block added to the standard library tend to break inference in the ecosystem in weird and wonderful ways.

kennytm · 2018-08-12T05:59:18Z

@bors try for crater

cc @rust-lang/infra

bors · 2018-08-12T05:59:29Z

⌛ Trying commit a7a0225 with merge bd6b537506d0e5e33051e42212b7027581b59a00...

bors · 2018-08-12T08:59:34Z

💔 Test failed - status-travis

kennytm · 2018-08-12T09:05:42Z

@bors retry

bors · 2018-08-12T09:05:51Z

⌛ Trying commit a7a0225 with merge 8bad4898151ee6feab25a9544d51f1863602172a...

bors · 2018-08-12T11:12:28Z

☀️ Test successful - status-travis
State: approved= try=True

weiznich · 2018-08-14T08:11:35Z

The bors build was successful. Who is responsible for triggering the crater run?

weiznich · 2018-08-15T20:33:36Z

@KodrAus @kennytm Any news about the crater run?

rfcbot · 2018-08-25T21:06:39Z

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2018-09-03T13:56:57Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2018-09-13T14:03:13Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

src/libcore/option.rs

Not yet relevant

kennytm · 2018-09-14T05:14:43Z

So would anyone from @rust-lang/libs wanna r+ before the actual branch off? 👀

KodrAus · 2018-09-14T06:40:43Z

@bors r+

bors · 2018-09-14T06:40:44Z

📌 Commit a7a0225 has been approved by KodrAus

@sgrif

…=KodrAus Add a implementation of `From` for converting `&'a Option<T>` into `Option<&'a T>` I'm not sure if any annotations regarding the stabilization are needed or in general what's the correct process of adding such an impl. cc @sgrif (We have talked about this)

@ghost

Rollup of 8 pull requests Successful merges: - #53218 (Add a implementation of `From` for converting `&'a Option<T>` into `Option<&'a T>`) - #54024 (Fix compiling some rustc crates to wasm) - #54095 (Rename all mentions of `nil` to `unit`) - #54173 (Suggest valid crate type if invalid crate type is found) - #54194 (Remove println!() statement from HashMap unit test) - #54203 (Fix the stable release of os_str_str_ref_eq) - #54207 (re-mark the never docs as unstable) - #54210 (Update Cargo) Failed merges: r? @ghost

bors · 2018-09-14T09:47:05Z

⌛ Testing commit a7a0225 with merge fccde00...

Add a implementation of From for converting &'a Option<T> into

ef519c1

`Option<&'a T>`

rust-highfive assigned KodrAus Aug 9, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2018

kennytm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Aug 9, 2018

This comment has been minimized.

Sign in to view

kennytm reviewed Aug 9, 2018

View reviewed changes

Add stability attribute

0cde1cb

Also add a From implementation for &mut Option<T> -> `Option<&mut…

a7a0225

… T>'

kennytm added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Aug 12, 2018

bors mentioned this pull request Aug 12, 2018

Rollup of 23 pull requests #53252

Closed

This comment has been minimized.

Sign in to view

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 12, 2018

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Aug 25, 2018

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Sep 3, 2018

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Sep 3, 2018

TimNN added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2018

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 13, 2018

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Sep 13, 2018

kennytm previously requested changes Sep 13, 2018

View reviewed changes

src/libcore/option.rs Show resolved Hide resolved

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2018

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2018

kennytm mentioned this pull request Sep 14, 2018

Rollup of 8 pull requests #54215

Merged

bors merged commit a7a0225 into rust-lang:master Sep 14, 2018

Centril added this to the 1.31 milestone Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a implementation of `From` for converting `&'a Option<T>` into `Option<&'a T>` #53218

Add a implementation of `From` for converting `&'a Option<T>` into `Option<&'a T>` #53218

weiznich commented Aug 9, 2018

rust-highfive commented Aug 9, 2018

This comment has been minimized.

kennytm Aug 9, 2018

clarfonthey commented Aug 9, 2018

KodrAus commented Aug 12, 2018

kennytm commented Aug 12, 2018

bors commented Aug 12, 2018

bors commented Aug 12, 2018

This comment has been minimized.

kennytm commented Aug 12, 2018

bors commented Aug 12, 2018

bors commented Aug 12, 2018

weiznich commented Aug 14, 2018

weiznich commented Aug 15, 2018

rfcbot commented Aug 25, 2018 •

edited by SimonSapin

Loading

rfcbot commented Sep 3, 2018

rfcbot commented Sep 13, 2018

kennytm commented Sep 14, 2018

KodrAus commented Sep 14, 2018

bors commented Sep 14, 2018

bors commented Sep 14, 2018

Add a implementation of From for converting &'a Option<T> into Option<&'a T> #53218

Add a implementation of From for converting &'a Option<T> into Option<&'a T> #53218

Conversation

weiznich commented Aug 9, 2018

rust-highfive commented Aug 9, 2018

This comment has been minimized.

kennytm Aug 9, 2018

Choose a reason for hiding this comment

clarfonthey commented Aug 9, 2018

KodrAus commented Aug 12, 2018

kennytm commented Aug 12, 2018

bors commented Aug 12, 2018

bors commented Aug 12, 2018

This comment has been minimized.

kennytm commented Aug 12, 2018

bors commented Aug 12, 2018

bors commented Aug 12, 2018

weiznich commented Aug 14, 2018

weiznich commented Aug 15, 2018

rfcbot commented Aug 25, 2018 • edited by SimonSapin Loading

rfcbot commented Sep 3, 2018

rfcbot commented Sep 13, 2018

kennytm commented Sep 14, 2018

KodrAus commented Sep 14, 2018

bors commented Sep 14, 2018

bors commented Sep 14, 2018

Add a implementation of `From` for converting `&'a Option<T>` into `Option<&'a T>` #53218

Add a implementation of `From` for converting `&'a Option<T>` into `Option<&'a T>` #53218

rfcbot commented Aug 25, 2018 •

edited by SimonSapin

Loading