Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add armv5te-unknown-linux-musl target #50423

Merged
merged 3 commits into from
May 5, 2018
Merged

Add armv5te-unknown-linux-musl target #50423

merged 3 commits into from
May 5, 2018

Conversation

hberntsen
Copy link

@hberntsen hberntsen commented May 3, 2018

This PR adds the armv5te-unknown-linux-musl target. The following steps should let you produce a fully statically linked binary now:

  1. Running ./src/ci/docker/run.sh dist-armv5te-linux-musl
  2. Changing the run.sh script to start bash instead of the build process and running the container
  3. export USER=root
    export PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin:$PATH
  4. Configuring Cargo
    [target.armv5te-unknown-linux-musl]
    linker = "arm-linux-gnueabi-gcc"
  5. Building a project
    cargo new --bin hello
    cd hello
    cargo build --target=armv5te-unknown-linux-musl --release

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2018
@alexcrichton
Copy link
Member

Thanks! Could the docker image here be moved to disabled because we're not gonna be running it on CI? Otherwise looks good to me!

@hberntsen
Copy link
Author

hberntsen commented May 3, 2018

@alexcrichton I'd like this target to be included in the tier 2 platform support like the armv5te-unknown-linux-gnueabi target. That target is built in the dist-various-1 container. I could add the musl one from this PR to that container if that suits you more. I could also add the new container to CI.

By the way, I noticed that in the target names both musl and musleabi is used, which one should I use for the target in this PR?

@nagisa
Copy link
Member

nagisa commented May 3, 2018

musleabi for 32-bit ARMs should be used.

@alexcrichton
Copy link
Member

Ah yeah adding to an existing container is best as it doesnt take up another builder with Travis, if that can be done then we can ship this yeah

@hberntsen
Copy link
Author

@alexcrichton Thanks! I've applied the suggested changes

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented May 4, 2018

📌 Commit 235af75 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 4, 2018
…l, r=alexcrichton

Add armv5te-unknown-linux-musl target

This PR adds the armv5te-unknown-linux-musl target. The following steps should let you produce a fully statically linked binary now:
1. Running `./src/ci/docker/run.sh dist-armv5te-linux-musl`
2. Changing the run.sh script to start bash instead of the build process and running the container
3.
   ```sh
   export USER=root
   export PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin:$PATH
   ```
4. Configuring Cargo
   ```yaml
   [target.armv5te-unknown-linux-musl]
   linker = "arm-linux-gnueabi-gcc"
   ```
5. Building a project
   ```sh
   cargo new --bin hello
   cd hello
   cargo build --target=armv5te-unknown-linux-musl --release
   ```
@bors
Copy link
Contributor

bors commented May 5, 2018

⌛ Testing commit 235af75 with merge fc6b2c5...

bors added a commit that referenced this pull request May 5, 2018
…ichton

Add armv5te-unknown-linux-musl target

This PR adds the armv5te-unknown-linux-musl target. The following steps should let you produce a fully statically linked binary now:
1. Running `./src/ci/docker/run.sh dist-armv5te-linux-musl`
2. Changing the run.sh script to start bash instead of the build process and running the container
3.
   ```sh
   export USER=root
   export PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin:$PATH
   ```
4. Configuring Cargo
   ```yaml
   [target.armv5te-unknown-linux-musl]
   linker = "arm-linux-gnueabi-gcc"
   ```
5. Building a project
   ```sh
   cargo new --bin hello
   cd hello
   cargo build --target=armv5te-unknown-linux-musl --release
   ```
@bors
Copy link
Contributor

bors commented May 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing fc6b2c5 to master...

@bors bors merged commit 235af75 into rust-lang:master May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants