Optimise min/max #47080
Merged
Optimise min/max #47080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swapping the conditions generates more efficient x86 assembly. See rust-lang#46926 (comment).
|
Reproduced on playground as well, and with different optimization settings (2 and 3, panic=unwind vs panic=abort). I spot checked Aarch64 asm and it's basically the same instructions with different operands (I trust both are correct and equally fast). |
|
@bors r+ |
|
📌 Commit fba16d3 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 31, 2017
Optimise min/max Swapping the conditions generates more efficient x86 assembly. See #46926 (comment). r? @rkruppe
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapping the conditions generates more efficient x86 assembly. See
#46926 (comment).
r? @rkruppe