Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hash impl for SystemTime and Instant #46828

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Add Hash impl for SystemTime and Instant #46828

merged 1 commit into from
Dec 20, 2017

Conversation

vi
Copy link
Contributor

@vi vi commented Dec 18, 2017

Closes #46670.

Not sure how to actually test non-Linux platforms.
rustc --target=i686-pc-windows-gnu --crate-name std --crate-type rlib src/libstd/lib.rs -o q.rlib works a bit, but for Redox I'm not sure what to do.

r? @dtolnay

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

dtolnay
dtolnay reviewed Dec 19, 2017
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me.

@dtolnay
Copy link
Member

dtolnay commented Dec 19, 2017

Regarding non-Linux platforms, I don't know either but we can see what CI says and go from there.

@bors try

@dtolnay dtolnay added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 19, 2017
@bors
Copy link
Contributor

bors commented Dec 19, 2017

⌛ Trying commit 1d5ead4 with merge 5bda5adfa1eec94bc3149b70b3bfb2bd242cbe42...

@dtolnay
Copy link
Member

dtolnay commented Dec 19, 2017

Since this is adding some new stable trait impls, let's run it by the rest of @rust-lang/libs as well.

impl Hash for std::time::Instant { /* ... */ }
impl Hash for std::time::SystemTime { /* ... */ }

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Dec 19, 2017 •
edited by aturon
Loading

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Dec 19, 2017
@bors
Copy link
Contributor

bors commented Dec 19, 2017

☀️ Test successful - status-travis
State: approved= try=True

@kennytm kennytm added the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label Dec 19, 2017
@rfcbot
Copy link

rfcbot commented Dec 19, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 19, 2017
@alexcrichton
Copy link
Member

@bors: r=dtolnay

@bors
Copy link
Contributor

bors commented Dec 19, 2017

📌 Commit 1d5ead4 has been approved by dtolnay

kennytm added a commit to kennytm/rust that referenced this pull request Dec 20, 2017
@kennytm
Rollup merge of rust-lang#46828 - vi:hash_for_systemtime_instant, r=d…
5e98112 
…tolnay

Add Hash impl for SystemTime and Instant

Closes rust-lang#46670.

Not sure how to actually test non-Linux platforms.
`rustc --target=i686-pc-windows-gnu --crate-name std --crate-type rlib src/libstd/lib.rs -o q.rlib` works a bit, but for Redox I'm not sure what to do.

r? @dtolnay
@kennytm kennytm mentioned this pull request Dec 20, 2017
Merged
@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Dec 20, 2017
bors added a commit that referenced this pull request Dec 20, 2017
@bors
Auto merge of #46874 - kennytm:rollup, r=kennytm
81622c6 
Rollup of 14 pull requests

- Successful merges: #46359, #46517, #46671, #46751, #46760, #46787, #46794, #46828, #46831, #46835, #46851, #46852, #46856, #46870
- Failed merges:
@bors bors merged commit 1d5ead4 into rust-lang:master Dec 20, 2017
@mbillingr mbillingr mentioned this pull request Mar 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees

@dtolnay dtolnay

Labels
final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vi @rust-highfive @dtolnay @bors @rfcbot @alexcrichton @kennytm