Stabilize the panic_col feature #46762

est31 · 2017-12-16T08:09:15Z

I've added the panic_col feature in PR #42938.
Now it's time to stabilize it!
Closes #42939.

rust-highfive · 2017-12-16T08:09:26Z

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

TimNN · 2017-12-17T20:28:54Z

cc @rust-lang/libs: There seems nothing more to do here, does this require any kind of FCP?

alexcrichton · 2017-12-18T15:10:31Z

@rfcbot fcp merge

Yeah for stabilizations we do indeed like to go through FCP!

rfcbot · 2017-12-18T15:10:32Z

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

Concerns:

0 resolved by Stabilize the panic_col feature #46762 (comment)

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

dtolnay · 2017-12-18T16:14:44Z

Is it intentional that line numbers in a panic start at 1 but column numbers start at 0? I see that this is what line!() and column!() do as well. What are the advantages? Is it too late to change?

fn main() {
panic!("line 2 column 0");
}

@rfcbot concern 0

sfackler · 2017-12-18T17:10:52Z

vim seems to start at 1 for lines and columns.

est31 · 2017-12-18T23:03:24Z

Compiler errors in both Rust and gcc start at 1 for columns as well. If you have code like:

fn main() {
 panic!("line 2 column 0");
}

Rust will say the column is 1 and if you do kate src/main.rs:linenum:1 then it jumps to the space, not the panic.

I'd say this is a off-by-one error and a bug in the actual code that emits the panic column info. I'd also say that it's a bug with the column!() macro but what to do about that one might be something for a later discussion.

est31 · 2017-12-18T23:07:11Z

Note that this code gives you the correct column number:

fn main() {
let v = [1,2,3];
v[7];
}

This is because this panic is directly emitted by the compiler and thus uses a separate way to obtain the column.

I guess I'll just add one to the column value for the panic macro case.

est31 · 2017-12-19T00:30:02Z

Not sure how to add a regression test for this. Any ideas?

sfackler · 2017-12-19T21:17:18Z

You should be able to make an rpass test that sets a panic handle that looks at the column.

est31 · 2017-12-20T01:24:49Z

@sfackler good idea, will do

dtolnay · 2017-12-20T05:35:24Z

@rfcbot resolved 0

dtolnay · 2017-12-20T06:00:57Z

We discussed this with the libs team and we would be interested in fixing the column!() macro as well. I filed #46868 to follow up in a separate PR.

est31 · 2017-12-23T23:47:26Z

I've marked this as WIP until the column issue is resolved.

est31 · 2017-12-27T18:01:31Z

#46977 is merged now!

I have added a test to verify that the returned column is 1 based.

@aturon @sfackler could you have a look and r+ the proposed FCP? Thanks!

alexcrichton · 2018-01-04T16:08:38Z

ping @aturon @sfackler, y'all may be interested in this!

sfackler · 2018-01-04T18:51:11Z

LGTM

est31 · 2018-01-04T20:18:09Z

@sfackler can you do rfcbot reviewed? Or can someone check it on @sfackler 's behalf?

carols10cents · 2018-01-09T14:49:58Z

ping @aturon this is waiting for your ticky box here!

rfcbot · 2018-01-09T21:10:23Z

🔔 This is now entering its final comment period, as per the review above. 🔔

alexcrichton · 2018-01-10T01:42:42Z

@bors: r+

bors · 2018-01-10T01:42:42Z

📌 Commit 131a9d8 has been approved by alexcrichton

goodmanjonathan · 2018-01-10T02:02:01Z

src/libstd/panicking.rs

@@ -329,7 +328,7 @@ impl<'a> Location<'a> {
    ///
    /// panic!("Normal panic");
    /// ```
-    #[unstable(feature = "panic_col", reason = "recently added", issue = "42939")]
+    #[stable(feature = "panic_col", since = "1.24")]


Shouldn't this be since = "1.25" now?

I've added the panic_col feature in PR rust-lang#42938. Now it's time to stabilize it! Closes rust-lang#42939.

est31 · 2018-01-10T02:25:32Z

re-r? @alexcrichton

alexcrichton · 2018-01-10T02:27:57Z

@bors: r+

bors · 2018-01-10T02:27:57Z

📌 Commit 2491814 has been approved by alexcrichton

frewsxcv · 2018-01-10T03:28:03Z

@bors rollup

Stabilize the panic_col feature I've added the panic_col feature in PR rust-lang#42938. Now it's time to stabilize it! Closes rust-lang#42939.

Rollup of 5 pull requests - Successful merges: #46762, #46777, #47262, #47285, #47301 - Failed merges:

bors · 2018-01-10T06:34:55Z

☔ The latest upstream changes (presumably #47308) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive assigned TimNN Dec 16, 2017

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Dec 16, 2017

rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Dec 18, 2017

alexcrichton assigned alexcrichton and unassigned TimNN Dec 18, 2017

est31 force-pushed the master branch from cd5a91d to 9c7b4f6 Compare December 19, 2017 00:28

dtolnay mentioned this pull request Dec 20, 2017

column!() should start at 1 not 0 #46868

Closed

est31 changed the title ~~Stabilize the panic_col feature~~ [WIP] Stabilize the panic_col feature Dec 23, 2017

est31 force-pushed the master branch 3 times, most recently from 0855471 to 131a9d8 Compare December 27, 2017 17:58

est31 changed the title ~~[WIP] Stabilize the panic_col feature~~ Stabilize the panic_col feature Dec 27, 2017

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 9, 2018

goodmanjonathan reviewed Jan 10, 2018

View reviewed changes

Stabilize the panic_col feature

a8556d7

I've added the panic_col feature in PR rust-lang#42938. Now it's time to stabilize it! Closes rust-lang#42939.

est31 force-pushed the master branch from 131a9d8 to 5cc7501 Compare January 10, 2018 02:25

We have Rust 1.25 now

2491814

est31 force-pushed the master branch from 5cc7501 to 2491814 Compare January 10, 2018 02:27

frewsxcv mentioned this pull request Jan 10, 2018

Rollup of 5 pull requests #47308

Merged

bors added a commit that referenced this pull request Jan 10, 2018

Auto merge of #47308 - frewsxcv:rollup, r=frewsxcv

92c32d2

Rollup of 5 pull requests - Successful merges: #46762, #46777, #47262, #47285, #47301 - Failed merges:

bors merged commit 2491814 into rust-lang:master Jan 10, 2018

est31 mentioned this pull request May 30, 2019

Tracking issue for proc_macro::Span inspection APIs #54725

Open

est31 mentioned this pull request Oct 15, 2019

Off-by-one in generated DWARF columns #65437

Closed

est31 mentioned this pull request Nov 12, 2020

Add column number support to Backtrace #79002

Merged

est31 mentioned this pull request Aug 19, 2023

adds a column number to dbg!() #114962

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize the panic_col feature #46762

Stabilize the panic_col feature #46762

est31 commented Dec 16, 2017

rust-highfive commented Dec 16, 2017

TimNN commented Dec 17, 2017

alexcrichton commented Dec 18, 2017

rfcbot commented Dec 18, 2017 •

edited by aturon

Loading

dtolnay commented Dec 18, 2017

sfackler commented Dec 18, 2017

est31 commented Dec 18, 2017

est31 commented Dec 18, 2017 •

edited

Loading

est31 commented Dec 19, 2017

sfackler commented Dec 19, 2017

est31 commented Dec 20, 2017

dtolnay commented Dec 20, 2017

dtolnay commented Dec 20, 2017

est31 commented Dec 23, 2017

est31 commented Dec 27, 2017 •

edited

Loading

alexcrichton commented Jan 4, 2018 •

edited

Loading

sfackler commented Jan 4, 2018

est31 commented Jan 4, 2018

carols10cents commented Jan 9, 2018

rfcbot commented Jan 9, 2018

alexcrichton commented Jan 10, 2018

bors commented Jan 10, 2018

goodmanjonathan Jan 10, 2018

est31 Jan 10, 2018

est31 commented Jan 10, 2018

alexcrichton commented Jan 10, 2018

bors commented Jan 10, 2018

frewsxcv commented Jan 10, 2018

bors commented Jan 10, 2018

Stabilize the panic_col feature #46762

Stabilize the panic_col feature #46762

Conversation

est31 commented Dec 16, 2017

rust-highfive commented Dec 16, 2017

TimNN commented Dec 17, 2017

alexcrichton commented Dec 18, 2017

rfcbot commented Dec 18, 2017 • edited by aturon Loading

dtolnay commented Dec 18, 2017

sfackler commented Dec 18, 2017

est31 commented Dec 18, 2017

est31 commented Dec 18, 2017 • edited Loading

est31 commented Dec 19, 2017

sfackler commented Dec 19, 2017

est31 commented Dec 20, 2017

dtolnay commented Dec 20, 2017

dtolnay commented Dec 20, 2017

est31 commented Dec 23, 2017

est31 commented Dec 27, 2017 • edited Loading

alexcrichton commented Jan 4, 2018 • edited Loading

sfackler commented Jan 4, 2018

est31 commented Jan 4, 2018

carols10cents commented Jan 9, 2018

rfcbot commented Jan 9, 2018

alexcrichton commented Jan 10, 2018

bors commented Jan 10, 2018

goodmanjonathan Jan 10, 2018

Choose a reason for hiding this comment

est31 Jan 10, 2018

Choose a reason for hiding this comment

est31 commented Jan 10, 2018

alexcrichton commented Jan 10, 2018

bors commented Jan 10, 2018

frewsxcv commented Jan 10, 2018

bors commented Jan 10, 2018

rfcbot commented Dec 18, 2017 •

edited by aturon

Loading

est31 commented Dec 18, 2017 •

edited

Loading

est31 commented Dec 27, 2017 •

edited

Loading

alexcrichton commented Jan 4, 2018 •

edited

Loading