Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #46360, re-enable macOS dist images. #46366

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Nov 29, 2017

This PR reverts #46360, which disabled all macOS dist images to workaround travis-ci/travis-ci#8821.

This PR should be merged as soon as the Travis bug has been fixed.

Closes #46357.

cc @rust-lang/infra

…1, r=kennytm"

This reverts commit dc0e227, reversing
changes made to 77ab3a1.

[skip ci]
@kennytm kennytm added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 29, 2017
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm
Copy link
Member Author

kennytm commented Nov 29, 2017

@bors p=2

@kennytm kennytm changed the title [WIP] Revert #46360, re-enable macOS dist images. Revert #46360, re-enable macOS dist images. Nov 29, 2017
@kennytm
Copy link
Member Author

kennytm commented Nov 29, 2017

@bors
Copy link
Contributor

bors commented Nov 29, 2017

📌 Commit 6b5f430 has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Nov 29, 2017
@bors
Copy link
Contributor

bors commented Nov 29, 2017

⌛ Testing commit 6b5f430 with merge cd19e5e...

bors added a commit that referenced this pull request Nov 29, 2017
Revert #46360, re-enable macOS dist images.

This PR reverts #46360, which disabled all macOS dist images to workaround travis-ci/travis-ci#8821.

This PR should be merged as soon as the Travis bug has been fixed.

Closes #46357.

cc @rust-lang/infra
@bors
Copy link
Contributor

bors commented Nov 29, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member Author

kennytm commented Nov 29, 2017

@bors retry

An Android test case segfaulted. I don't think it is caused by this PR.

[01:10:57] test net::tcp::tests::debug ... ok
[01:10:58] test net::tcp::tests::double_bind ... ok
[01:10:58] test net::tcp::tests::fast_rebind ... ok
[01:10:58] test net::tcp::tests::listen_localhost ... ok
[01:10:59] died due to signal 11
[01:10:59] �[m�[m�[31m�[1merror:�[m test failed, to rerun pass '--lib'
[01:10:59] 
[01:10:59] 
[01:10:59] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "std:0.0.0" "-p" "unwind:0.0.0" "-p" "compiler_builtins:0.0.0" "-p" "alloc:0.0.0" "-p" "alloc_system:0.0.0" "-p" "std_unicode:0.0.0" "-p" "libc:0.0.0" "-p" "panic_abort:0.0.0" "-p" "core:0.0.0" "--"
[01:10:59] expected success, got: exit code: 3
[01:10:59] 
[01:10:59] 
[01:10:59] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target arm-linux-androideabi
[01:10:59] Build completed unsuccessfully in 1:08:10

@bors
Copy link
Contributor

bors commented Nov 29, 2017

⌛ Testing commit 6b5f430 with merge 29de30d8e7e98611429d7dbc117f9eefd50762c9...

@bors
Copy link
Contributor

bors commented Nov 29, 2017

💔 Test failed - status-appveyor

@kennytm
Copy link
Member Author

kennytm commented Nov 29, 2017

@bors retry — 3 hour timeout.

It spent >30 minutes in compiling stage1-rustc and also >30 minutes in running run-pass tests. Something regressed the 32-bit performance a lot.

@bors
Copy link
Contributor

bors commented Nov 30, 2017

⌛ Testing commit 6b5f430 with merge 78fcf33...

bors added a commit that referenced this pull request Nov 30, 2017
Revert #46360, re-enable macOS dist images.

This PR reverts #46360, which disabled all macOS dist images to workaround travis-ci/travis-ci#8821.

This PR should be merged as soon as the Travis bug has been fixed.

Closes #46357.

cc @rust-lang/infra
@bors
Copy link
Contributor

bors commented Nov 30, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 78fcf33 to master...

@bors bors merged commit 6b5f430 into rust-lang:master Nov 30, 2017
@kennytm kennytm deleted the revert-46360 branch November 30, 2017 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All bors builds failing on xcode 7.3
4 participants