Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a trailling comma in assert_eq/ne macro #45887

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Allow a trailling comma in assert_eq/ne macro #45887

merged 1 commit into from
Nov 10, 2017

Conversation

KamilaBorowska
Copy link
Contributor

@KamilaBorowska KamilaBorowska commented Nov 9, 2017 •
edited
Loading

From Rust beginners IRC:

<???> It sure does annoy me that assert_eq!() does not accept a trailing comma after the last argument.
<???> ???: File an issue against https://github.com/rust-lang/rust and CC @rust-lang/libs

Figured that might as well submit it. Will become insta-stable after merging (danger zone).

cc @rust-lang/libs

@KamilaBorowska KamilaBorowska force-pushed the assert-eq-trailling-comma branch from 344c59f to 9b2e78a Compare November 9, 2017 11:48
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 9, 2017
@kennytm
Copy link
Member

kennytm commented Nov 9, 2017

cc @rust-lang/libs @zackmdavis

@KamilaBorowska
Copy link
Contributor Author

By the way, assert_eq!(1, 1, "description",); already works due to format_args macro allowing trailing commas.

@KamilaBorowska KamilaBorowska force-pushed the assert-eq-trailling-comma branch from 9b2e78a to 5e1f697 Compare November 9, 2017 12:48
@KamilaBorowska KamilaBorowska force-pushed the assert-eq-trailling-comma branch from 5e1f697 to 6a92c0f Compare November 9, 2017 13:15
dtolnay
dtolnay approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems good to me.

@dtolnay
Copy link
Member

dtolnay commented Nov 9, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 9, 2017

📌 Commit 6a92c0f has been approved by dtolnay

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 10, 2017
@kennytm
Rollup merge of rust-lang#45887 - xfix:assert-eq-trailling-comma, r=d…
253d18e 
…tolnay

Allow a trailling comma in assert_eq/ne macro

From Rust beginners IRC:

&lt;???> It sure does annoy me that assert_eq!() does not accept a trailing comma after the last argument.
&lt;???> ???: File an issue against https://github.com/rust-lang/rust and CC @rust-lang/libs

Figured that might as well submit it. Will become insta-stable after merging (danger zone).

cc @rust-lang/libs
@kennytm kennytm mentioned this pull request Nov 10, 2017
Merged
bors added a commit that referenced this pull request Nov 10, 2017
@bors
Auto merge of #45907 - kennytm:rollup, r=kennytm
c0d326f 
Rollup of 9 pull requests

- Successful merges: #45783, #45856, #45863, #45869, #45878, #45882, #45887, #45895, #45901
- Failed merges:
@bors bors merged commit 6a92c0f into rust-lang:master Nov 10, 2017
@colin-kiegel colin-kiegel mentioned this pull request Nov 26, 2017
Closed
@dtolnay dtolnay self-assigned this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KamilaBorowska @kennytm @dtolnay @bors