Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regenerate libcore/char_private.rs #45571

Merged
merged 1 commit into from
Nov 7, 2017
Merged

regenerate libcore/char_private.rs #45571

merged 1 commit into from
Nov 7, 2017

Conversation

zackmdavis
Copy link
Member

(filed separately from the work in #45569, because of this matter of the updated Unicode data; see also #45567)

char_private.rs is generated programmatically by char_private.py, using data retrieved from the Unicode Consortium's website.

The motivation here was to make is_printable crate-visible (with pub(crate)), but it would seem that the Unicode data has changed slightly since char_private.rs was last generated.

@zackmdavis
regenerate libcore/char_private.rs
3c81d3d 
char_private.rs is generated programmatically by char_private.py, using data
retrieved from the Unicode Consortium's website.

The motivation here was to make `is_printable` crate-visible (with
`pub(crate)`), but it would seem that the Unicode data has changed slightly
since char_private.rs was last generated.
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 27, 2017
@estebank
Copy link
Contributor

Sorry for the wide spam, @rust-lang/core, @rust-lang/libs, @rust-lang/docs not sure who to ask this.

This change will update Rust's unicode support from 9 to 10, IIUC. Is this something that can be updated matter of fact without an RFC? I'm inclined to r+ it, maybe changing the PR's name beforehand to make sure it's not lost in the shuffle in the corresponding release's notes.

@kennytm kennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 1, 2017
@kennytm
Copy link
Member

kennytm commented Nov 1, 2017

@estebank We should be already using Unicode 10 (#42999)...

Similar previous PRs (e.g. upgrade entirely to Unicode 9 #34599) don't have RFCs, but they don't pass as a single-handed r+ either.

However, the char_private module only defines the is_printable function, which in turn is only used in char::escape_debug that has no stability guarantee on the Unicode version. So I guess it is fine to merge without deep inspection.

@alexcrichton
Copy link
Member

@bors: r+

Thanks for the extra info @kennytm!

@bors
Copy link
Contributor

bors commented Nov 6, 2017

📌 Commit 3c81d3d has been approved by alexcrichton

@alexcrichton alexcrichton added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2017
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. relnotes Marks issues that should be documented in the release notes of the next release. labels Nov 7, 2017
@kennytm
Copy link
Member

kennytm commented Nov 7, 2017

(I've removed the relnotes tag since it only affects escape_debug which doesn't seem to be a big point to mention.)

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2017
@bors
Copy link
Contributor

bors commented Nov 7, 2017

⌛ Testing commit 3c81d3d with merge a17e724...

bors added a commit that referenced this pull request Nov 7, 2017
@bors
Auto merge of #45571 - zackmdavis:regenerate_char_private, r=alexcric…
a17e724 
…hton

regenerate libcore/char_private.rs

(filed separately from the work in #45569, because of this matter of the updated Unicode data; see also #45567)

char_private.rs is generated programmatically by char_private.py, using data retrieved from the Unicode Consortium's website.

The motivation here was to make `is_printable` crate-visible (with `pub(crate)`), but it would seem that the Unicode data has changed slightly since char_private.rs was last generated.
@Mark-Simulacrum Mark-Simulacrum added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 7, 2017
@Mark-Simulacrum
Copy link
Member

I disagree - I think this change is worth mentioning in the compatibility section of the relnotes.

@bors
Copy link
Contributor

bors commented Nov 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a17e724 to master...

@bors bors merged commit 3c81d3d into rust-lang:master Nov 7, 2017
@zackmdavis zackmdavis deleted the regenerate_char_private branch January 13, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zackmdavis @rust-highfive @estebank @kennytm @alexcrichton @bors @Mark-Simulacrum @aturon