Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the minimum LLVM to 3.9 #45326

Merged
merged 4 commits into from
Oct 18, 2017
Merged

Bump the minimum LLVM to 3.9 #45326

merged 4 commits into from
Oct 18, 2017

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Oct 16, 2017

Old LLVM bugs are reportedly cropping up harder, but 3.9 seems to be OK.

Fixes #45277.

@cuviper
Bump the minimum LLVM to 3.9
68311bd 
Old LLVM bugs are reportedly cropping up harder, but 3.9 seems to be OK.

Fixes rust-lang#45277.
@cuviper
Update the codegen/mainsubprogram tests to min-llvm 4.0
7538a9b 
The necessary changes were only in upstream LLVM in 4.0, but they were
for a while backported to Rust LLVM.  Now that Rust LLVM is also 4.0, we
can make the test conditional here more accurate.
@cuviper
bootstrap: update and enable the LLVM version-check
6f33108 
While the `config.toml.example` comments say "we automatically check the
version by default," we actually didn't.  That check was badly out of
date, only allowing 3.5, 3.6, or 3.7.  This it now updated to the new
3.9 minimum requirement, and truly enabled by default.
@cuviper
Copy link
Member Author

cuviper commented Oct 16, 2017

Everyone in #45277 seemed to agree that LLVM 3.9 is fine for the minimum, but we may need to identify more folks to ask and make sure. IIRC @brson had a list of distro contacts - did he pass that on?

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 17, 2017

📌 Commit 6f33108 has been approved by alexcrichton

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 17, 2017
@eddyb
Copy link
Member

eddyb commented Oct 18, 2017

@bors r-

You should also remove // min-llvm-version 3.9 from src/test/run-pass/issue-36023.rs.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 18, 2017
@cuviper
Copy link
Member Author

cuviper commented Oct 18, 2017

@eddyb -- I removed that and one for 3.8.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 18, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 18, 2017

📌 Commit 6309a47 has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 18, 2017
@kennytm
Rollup merge of rust-lang#45326 - cuviper:min-llvm-3.9, r=alexcrichton
c77068a 
Bump the minimum LLVM to 3.9

Old LLVM bugs are reportedly cropping up harder, but 3.9 seems to be OK.

Fixes rust-lang#45277.
@kennytm kennytm mentioned this pull request Oct 18, 2017
Merged
bors added a commit that referenced this pull request Oct 18, 2017
@bors
Auto merge of #45368 - kennytm:rollup, r=kennytm
b796087 
Rollup of 10 pull requests

- Successful merges: #44138, #45082, #45098, #45181, #45217, #45281, #45325, #45326, #45340, #45354
- Failed merges:
@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 18, 2017
@alexcrichton alexcrichton merged commit 6309a47 into rust-lang:master Oct 18, 2017
@cuviper cuviper deleted the min-llvm-3.9 branch October 19, 2017 23:29
cuviper added a commit to cuviper/rust that referenced this pull request Dec 1, 2017
@cuviper
rustllvm: Remove conditional code for LLVM < 3.9
51342f1 
We bumped the minimum LLVM to 3.9 in rust-lang#45326.  This just cleans up the
conditional code in the rustllvm C++ wrappers to assume at least 3.9.
@cuviper cuviper mentioned this pull request Dec 1, 2017
Merged
bors added a commit that referenced this pull request Dec 3, 2017
@bors
Auto merge of #46435 - cuviper:min-llvm-3.9, r=rkruppe
1956d55 
Assume at least LLVM 3.9 in rustllvm and rustc_llvm

We bumped the minimum LLVM to 3.9 in #45326.  This just cleans up the conditional code in the `rustllvm` C++ wrappers to assume that minimum, and similarly cleans up the `rustc_llvm` build script.
@cuviper cuviper mentioned this pull request Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cuviper @alexcrichton @bors @eddyb @kennytm