Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Reduce default CGUs to 16 #45064

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

alexcrichton
Copy link
Member

Rationale explained in the included comment as well as #44941

Rationale explained in the included comment as well as rust-lang#44941
@alexcrichton
Copy link
Member Author

r? @michaelwoerister

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@michaelwoerister
Copy link
Member

@bors r+

We should try to measure the effects of not duplicating inline functions soon. I'd be very interested in that.

@bors
Copy link
Contributor

bors commented Oct 6, 2017

📌 Commit 1988447 has been approved by michaelwoerister

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 6, 2017
@alexcrichton
Copy link
Member Author

Indeed yeah! I'm going to try to work on that locally when I can

@bors
Copy link
Contributor

bors commented Oct 9, 2017

⌛ Testing commit 1988447 with merge d7acd29...

bors added a commit that referenced this pull request Oct 9, 2017
…erister

rustc: Reduce default CGUs to 16

Rationale explained in the included comment as well as #44941
@bors
Copy link
Contributor

bors commented Oct 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing d7acd29 to master...

@bors bors merged commit 1988447 into rust-lang:master Oct 9, 2017
@alexcrichton alexcrichton deleted the reduce-codegen-units branch October 10, 2017 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants