Add Cow<str> -> Box<Error> impls. #44466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
added
the
T-libs-api
|
Seems reasonable to me @rfcbot fcp merge |
rfcbot
added
the
proposed-final-comment-period
|
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
kennytm
reviewed
Sep 10, 2017
| @@ -217,6 +217,20 @@ impl<'a> From<&'a str> for Box<Error> { | |||
| } | |||
| } | |||
|
|
|||
| #[stable(feature = "cow_box_error", since = "1.22.0")] | |||
| impl<'a, 'b> From<Cow<'b, str>> for Box<Error + Send + Sync + 'a> { | |||
There was a problem hiding this comment.
Needs to import Cow.
[00:03:22] error[E0412]: cannot find type `Cow` in this scope
[00:03:22] --> /checkout/src/libstd/error.rs:221:19
[00:03:22] |
[00:03:22] 221 | impl<'a, 'b> From<Cow<'b, str>> for Box<Error + Send + Sync + 'a> {
[00:03:22] | ^^^ not found in this scope
[00:03:22] |
[00:03:22] help: possible candidate is found in another module, you can import it into scope
[00:03:22] |
[00:03:22] 66 | use alloc::borrow::Cow;There was a problem hiding this comment.
That was a silly error. Fixed.
clarfonthey
force-pushed
the
cow_error
branch
from
b0adb44 to
778d5f2
Compare
carols10cents
added
the
S-waiting-on-team
rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
@bors: r+ |
|
📌 Commit 778d5f2 has been approved by |
aidanhs
added
S-waiting-on-bors
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 18, 2017
Add Cow<str> -> Box<Error> impls. Considering how impls exist for `String` and `&str`, it makes sense to also add an impl for `Cow<str>` as well. This would allow converting `String::from_utf8_lossy` directly into a `Box<Error>` or `io::Error` without having to add an extra `into_ownd()`.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 18, 2017
Add Cow<str> -> Box<Error> impls. Considering how impls exist for `String` and `&str`, it makes sense to also add an impl for `Cow<str>` as well. This would allow converting `String::from_utf8_lossy` directly into a `Box<Error>` or `io::Error` without having to add an extra `into_ownd()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering how impls exist for
Stringand&str, it makes sense to also add an impl forCow<str>as well.This would allow converting
String::from_utf8_lossydirectly into aBox<Error>orio::Errorwithout having to add an extrainto_ownd().