Implement AsRawFd for Stdin, Stdout, and Stderr #43459

ids1024 · 2017-07-24T21:48:31Z

rust-lang/rfcs#2074

rust-highfive · 2017-07-24T21:48:42Z

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2017-07-25T21:21:59Z

Thanks for the PR! My only point of hesitation here is that these structures are internally buffered (stdin and stdout at least) and AFAIK we don't implement as_raw_fd for the BufReader type. I'd personally prefer to avoid this for now until we eventually expose types like StdinRaw and such, but that needs more work on Windows I believe to get working.

@rust-lang/libs, do others have thoughts?

sfackler · 2017-07-25T21:27:48Z

I think we should just add StdinRaw &co now - they're pretty trivial to make.

BurntSushi · 2017-07-25T21:54:34Z

src/libstd/sys/redox/ext/io.rs

@@ -109,6 +110,21 @@ impl AsRawFd for net::UdpSocket {
    }
 }

+#[stable(feature = "rust1", since = "1.0.0")]


I think this should be 1.21.0? (Someone check me on the exact version.)

What should feature be? I don't know exactly how this works, since trait implementations aren't behind feature flags.

You can pick a new feature name for this

BurntSushi · 2017-07-25T21:54:42Z

src/libstd/sys/unix/ext/io.rs

@@ -104,6 +106,21 @@ impl AsRawFd for net::UdpSocket {
    fn as_raw_fd(&self) -> RawFd { *self.as_inner().socket().as_inner() }
 }

+#[stable(feature = "rust1", since = "1.0.0")]


alexcrichton · 2017-07-25T23:32:33Z

@sfackler IIRC the implementation on Windows is pretty nontrivial, in that neither Read nor Write can be implemented.

sfackler · 2017-07-25T23:50:18Z

Oh, right. I guess it could live in std::os::unix::io?

alexcrichton · 2017-07-26T01:58:42Z

Yeah that seems plausible to me. Either that or we could have std::io::StdoutRaw and it just has no methods other than ::new. All methods would be layered on from extension traits in the OS modules.

alexcrichton · 2017-07-27T23:14:56Z

@sfackler @BurntSushi do y'all have thoughts on specifically not providing this impl on the existing types? My rationale is that they're buffered so they're not quite as "raw" as you'd like, but I'm curious what others' opinions are.

BurntSushi · 2017-07-28T10:59:39Z

@alexcrichton From my perspective, I think all I really care about is just being able to get the std file descriptors easily. It's purely a convenience. I think I'd be just as happy with them existing on the "raw" types. I do somewhat share your concern that getting a file descriptor on something that is buffered is a little strange, although I think the C function fileno conceptually does the same thing? So there's a little bit of precedent there?

sfackler · 2017-07-28T19:35:20Z

I think it is worth having the impls on the buffered versions - we can call out the fact that they are buffered on the impl docs which should help avoid confusion there.

alexcrichton · 2017-07-28T22:21:53Z

Ok, that sounds convincing enough to me, let's see abuot landing this and pursuing the raw versions independently.

@ids1024 would you be ok adding AsRawHandle implementations for Windows as well?

@rfcbot fcp merge

alexcrichton · 2017-07-29T00:26:54Z

@rfcbot fcp merge

rfcbot · 2017-07-29T01:09:11Z

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

aturon · 2017-08-01T20:55:08Z

(I checked for @brson, who is away)

rfcbot · 2017-08-01T21:40:36Z

🔔 This is now entering its final comment period, as per the review above. 🔔

alexcrichton · 2017-08-01T21:59:30Z

@bors: r+

Alright, thanks @ids1024!

bors · 2017-08-01T21:59:31Z

📌 Commit a878592 has been approved by alexcrichton

bors · 2017-08-02T14:40:35Z

📌 Commit 578123c has been approved by alexcrichton

bors · 2017-08-02T16:15:25Z

⌛ Testing commit 578123c2dc180d805077b4cd364988561240bcf2 with merge 52cb406a7b6c756132a5330d739db6cdc82b8b1c...

bors · 2017-08-02T16:21:33Z

💔 Test failed - status-appveyor

aidanhs · 2017-08-03T19:10:15Z

@bors r=alexcrichton

bors · 2017-08-03T19:10:16Z

📌 Commit 303488a has been approved by alexcrichton

bors · 2017-08-03T19:34:29Z

⌛ Testing commit 303488a2643edb358566bd9a66b7a92a66ae4b4e with merge d6a38980c652ebce967585d6eeb8b0a8c23d166f...

bors · 2017-08-03T19:40:25Z

💔 Test failed - status-appveyor

aidanhs · 2017-08-03T20:31:01Z

@bors r=alexcrichton

bors · 2017-08-03T20:31:02Z

📌 Commit eac01f1 has been approved by alexcrichton

bors · 2017-08-03T22:14:33Z

⌛ Testing commit eac01f1 with merge 9f5d7a2b7b43ef29a2161f69b35e48c39afd08c7...

bors · 2017-08-03T22:20:29Z

💔 Test failed - status-appveyor

aidanhs · 2017-08-04T02:14:59Z

@bors r=alexcrichton

bors · 2017-08-04T02:14:59Z

📌 Commit 64e426e has been approved by alexcrichton

bors · 2017-08-04T02:15:10Z

⌛ Testing commit 64e426e with merge eae446c...

Implement AsRawFd for Stdin, Stdout, and Stderr rust-lang/rfcs#2074

bors · 2017-08-04T04:35:54Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing eae446c to master...

malbarbo · 2017-08-09T12:19:24Z

@alexcrichton This fixes #40007

Changelog: Version 1.21.0 (2017-10-12) ========================== Language -------- - [You can now use static references for literals.][43838] Example: ```rust fn main() { let x: &'static u32 = &0; } ``` - [Relaxed path syntax. Optional `::` before `<` is now allowed in all contexts.][43540] Example: ```rust my_macro!(Vec<i32>::new); // Always worked my_macro!(Vec::<i32>::new); // Now works ``` Compiler -------- - [Upgraded jemalloc to 4.5.0][43911] - [Enabled unwinding panics on Redox][43917] - [Now runs LLVM in parallel during translation phase.][43506] This should reduce peak memory usage. Libraries --------- - [Generate builtin impls for `Clone` for all arrays and tuples that are `T: Clone`][43690] - [`Stdin`, `Stdout`, and `Stderr` now implement `AsRawFd`.][43459] - [`Rc` and `Arc` now implement `From<&[T]> where T: Clone`, `From<str>`, `From<String>`, `From<Box<T>> where T: ?Sized`, and `From<Vec<T>>`.][42565] Stabilized APIs --------------- [`std::mem::discriminant`] Cargo ----- - [You can now call `cargo install` with multiple package names][cargo/4216] - [Cargo commands inside a virtual workspace will now implicitly pass `--all`][cargo/4335] - [Added a `[patch]` section to `Cargo.toml` to handle prepublication dependencies][cargo/4123] [RFC 1969] - [`include` & `exclude` fields in `Cargo.toml` now accept gitignore like patterns][cargo/4270] - [Added the `--all-targets` option][cargo/4400] - [Using required dependencies as a feature is now deprecated and emits a warning][cargo/4364] Misc ---- - [Cargo docs are moving][43916] to [doc.rust-lang.org/cargo](https://doc.rust-lang.org/cargo) - [The rustdoc book is now available][43863] at [doc.rust-lang.org/rustdoc](https://doc.rust-lang.org/rustdoc) - [Added a preview of RLS has been made available through rustup][44204] Install with `rustup component add rls-preview` - [`std::os` documentation for Unix, Linux, and Windows now appears on doc.rust-lang.org][43348] Previously only showed `std::os::unix`. Compatibility Notes ------------------- - [Changes in method matching against higher-ranked types][43880] This may cause breakage in subtyping corner cases. [A more in-depth explanation is available.][info/43880] - [rustc's JSON error output's byte position start at top of file.][42973] Was previously relative to the rustc's internal `CodeMap` struct which required the unstable library `libsyntax` to correctly use. - [`unused_results` lint no longer ignores booleans][43728] [42565]: rust-lang/rust#42565 [42973]: rust-lang/rust#42973 [43348]: rust-lang/rust#43348 [43459]: rust-lang/rust#43459 [43506]: rust-lang/rust#43506 [43540]: rust-lang/rust#43540 [43690]: rust-lang/rust#43690 [43728]: rust-lang/rust#43728 [43838]: rust-lang/rust#43838 [43863]: rust-lang/rust#43863 [43880]: rust-lang/rust#43880 [43911]: rust-lang/rust#43911 [43916]: rust-lang/rust#43916 [43917]: rust-lang/rust#43917 [44204]: rust-lang/rust#44204 [cargo/4123]: rust-lang/cargo#4123 [cargo/4216]: rust-lang/cargo#4216 [cargo/4270]: rust-lang/cargo#4270 [cargo/4335]: rust-lang/cargo#4335 [cargo/4364]: rust-lang/cargo#4364 [cargo/4400]: rust-lang/cargo#4400 [RFC 1969]: rust-lang/rfcs#1969 [info/43880]: rust-lang/rust#44224 (comment) [`std::mem::discriminant`]: https://doc.rust-lang.org/std/mem/fn.discriminant.html

Implement AsRawFd for Stdin, Stdout, and Stderr

85ef570

rust-highfive assigned brson Jul 24, 2017

rust-highfive assigned alexcrichton and unassigned brson Jul 25, 2017

BurntSushi reviewed Jul 25, 2017

View reviewed changes

Correct 'stable' attribute

e9c55d1

alexcrichton added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2017

rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jul 29, 2017

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 1, 2017

aidanhs added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Aug 3, 2017

Implement AsRawHandle for Std* on Windows

eac01f1

ids1024 force-pushed the asrawfd branch from 303488a to eac01f1 Compare August 3, 2017 19:59

Fix AsRawHandle

64e426e

bors added a commit that referenced this pull request Aug 4, 2017

Auto merge of #43459 - ids1024:asrawfd, r=alexcrichton

eae446c

Implement AsRawFd for Stdin, Stdout, and Stderr rust-lang/rfcs#2074

bors merged commit 64e426e into rust-lang:master Aug 4, 2017

alexcrichton mentioned this pull request Aug 9, 2017

Consider implementing AsRawFd for Stdout, Stdin and Stderr #40007

Closed

ids1024 deleted the asrawfd branch October 5, 2017 14:44

oconnor663 mentioned this pull request Oct 10, 2017

stdin/stdout/stderr now implement AsRawFd oconnor663/os_pipe.rs#11

Open

Implement AsRawFd for Stdin, Stdout, and Stderr #43459

Implement AsRawFd for Stdin, Stdout, and Stderr #43459

Conversation

ids1024 commented Jul 24, 2017

rust-highfive commented Jul 24, 2017

alexcrichton commented Jul 25, 2017

sfackler commented Jul 25, 2017

BurntSushi Jul 25, 2017

Choose a reason for hiding this comment

ids1024 Jul 25, 2017

Choose a reason for hiding this comment

alexcrichton Jul 25, 2017

Choose a reason for hiding this comment

BurntSushi Jul 25, 2017

Choose a reason for hiding this comment

alexcrichton commented Jul 25, 2017

sfackler commented Jul 25, 2017

alexcrichton commented Jul 26, 2017

alexcrichton commented Jul 27, 2017

BurntSushi commented Jul 28, 2017

sfackler commented Jul 28, 2017

alexcrichton commented Jul 28, 2017

alexcrichton commented Jul 29, 2017

rfcbot commented Jul 29, 2017 • edited by aturon Loading

aturon commented Aug 1, 2017

rfcbot commented Aug 1, 2017

alexcrichton commented Aug 1, 2017

bors commented Aug 1, 2017

bors commented Aug 2, 2017

bors commented Aug 2, 2017

bors commented Aug 2, 2017

aidanhs commented Aug 3, 2017

bors commented Aug 3, 2017

bors commented Aug 3, 2017

bors commented Aug 3, 2017

aidanhs commented Aug 3, 2017

bors commented Aug 3, 2017

bors commented Aug 3, 2017

bors commented Aug 3, 2017

aidanhs commented Aug 4, 2017

bors commented Aug 4, 2017

bors commented Aug 4, 2017

bors commented Aug 4, 2017

malbarbo commented Aug 9, 2017

rfcbot commented Jul 29, 2017 •

edited by aturon

Loading