Speed up expansion #42533
Merged
Speed up expansion #42533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
added
the
relnotes
Mark-Simulacrum
force-pushed
the
macro-parse-speed-small
branch
from
9b86af6 to
1b6c57b
Compare
eddyb
reviewed
Jun 8, 2017
| impl MatcherPos { | ||
| fn push_match(&mut self, idx: usize, m: NamedMatch) { | ||
| let matches = Rc::make_mut(&mut self.matches[idx]); | ||
| matches.push(m); |
This reduces duplication, thereby increasing expansion speed.
Mark-Simulacrum
force-pushed
the
macro-parse-speed-small
branch
from
1b6c57b to
3d9ebf2
Compare
|
Pushed a theoretical fix for the run-pass-fulldeps test. I think it ran locally, but not sure. The full deps tests always get me. |
alexcrichton
added
the
S-waiting-on-review
|
Excellent! |
|
📌 Commit 3d9ebf2 has been approved by |
|
⌛ Testing commit 3d9ebf2 with merge d9d8f66... |
|
💔 Test failed - status-appveyor |
|
@bors retry Seems like a spurious issue. |
bors
added a commit
that referenced
this pull request
Jun 10, 2017
…yfried Speed up expansion This reduces duplication, thereby increasing expansion speed. Based on tests with rust-uinput, this produces a 29x performance win (440 seconds to 15 seconds). I want to land this first, since it's a minimal patch, but with more changes to the macro parsing I can get down to 12 seconds locally. There is one FIXME added to the code that I'll keep for now since changing it will spread outward and increase the patch size, I think. Fixes #37074. r? @jseyfried cc @oberien
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces duplication, thereby increasing expansion speed. Based on tests with rust-uinput, this produces a 29x performance win (440 seconds to 15 seconds). I want to land this first, since it's a minimal patch, but with more changes to the macro parsing I can get down to 12 seconds locally.
There is one FIXME added to the code that I'll keep for now since changing it will spread outward and increase the patch size, I think.
Fixes #37074.
r? @jseyfried
cc @oberien