Fix options passed to gpg in cargo init #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catamorphism
added a commit
that referenced
this pull request
Dec 23, 2012
Fix options passed to gpg in cargo init
|
Hi Martin :-) Merged, thanks! |
|
This commit breaks signature verification and should just be reverted... |
|
yes, sorry about that - turns out i was coding against a buggy archlinux gnupg package that had symlinked gpgv to gpg2 rather than gpgv2. on the other hand reverting this will break cargo on arch again; maybe there should be something in a readme about it. |
|
That seems to be a problem with archlinux--we shouldn't break the correct behavior in rust just to support one buggy distro. I agree that the documentation should mention this but this commit definitely needs to be reverted--it does not do the right thing. |
vertexclique
pushed a commit
to vertexclique/rust
that referenced
this pull request
Feb 11, 2014
As per rust-lang#4253 This reverts commit 6c05697.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
bump rustfmt 1.x rustc-ap* crates to v644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like someone autoexpanded -v :)