impl Clone for .split_whitespace() #41659
Conversation
Use custom closure structs for the predicates so that the iterator's clone can simply be derived. This should also reduce virtual call overhead by not using function pointers.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
It's not pretty but I think it's OK to use this long kind of implementation due to its positive features. |
carols10cents
added
the
S-waiting-on-review
|
r? @aturon |
|
cc @rust-lang/libs (code seems fine to me; and I can't see any reason that this iterator shouldn't be iterable...) |
alexcrichton
added
the
T-libs-api
|
@rfcbot fcp merge |
|
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
|
LGTM. r=me once libs has signed off (new stable addition to std). |
Mark-Simulacrum
added
S-waiting-on-team
|
@bors: r+ |
|
📌 Commit 41aeb9d has been approved by |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
added
the
final-comment-period
impl Clone for .split_whitespace() Use custom closure structs for the predicates so that the iterator's clone can simply be derived. This should also reduce virtual call overhead by not using function pointers. Fixes #41655
|
☀️ Test successful - status-appveyor, status-travis |
bluss
added
the
relnotes
Use custom closure structs for the predicates so that the iterator's
clone can simply be derived. This should also reduce virtual call
overhead by not using function pointers.
Fixes #41655