sparc64-linux support #38726

japaric · 2016-12-31T01:51:53Z

This is built on top of #38656 and depends on rust-lang/libc#483

Hello world works.

The libc-test test suite passes.

panic! doesn't fully work:

$ qemu-sparc64-static ./panic
thread 'main' panicked at 'explicit panic', panic.rs:1
note: Run with `RUST_BACKTRACE=1` for a backtrace.
Illegal instruction (core dumped)

Backtraces don't work either, probably related to the previous point:

$ export RUST_BACKTRACE=1
$ qemu-sparc64-static ./panic
thread 'main' panicked at 'explicit panic', panic.rs:1
stack backtrace:
Illegal instruction (core dumped)

r? @alexcrichton

@jakllsch Does panicking / backtraces work on sparc64-netbsd?

cc @glaubitz

rust-highfive · 2016-12-31T01:52:06Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

glaubitz · 2016-12-31T02:09:26Z

@japaric If you rather want to debug on a real machine than on qemu, let me know. If you like, please join us in #sparc on Freenode.

jrtc27 · 2016-12-31T02:19:25Z

At a glance, the C ABI seems wrong; small structs should be passed in and returned in registers.

jakllsch · 2016-12-31T02:24:23Z

@japaric Yes, backtrace of fn main() { println!("Goodbye World!"); panic!(); } produces an identical backtrace (with RUST_BACKTRACE=1) on NetBSD/amd64 and NetBSD/sparc64 (excepting differences in addresses within the .text segment) with #38656. Had to use -C linker=sparc64--netbsd-gcc (the same wrapper gcc-rs points the rustbuild at) in addition to --target sparc64-unknown-netbsd to get it to cross link.

jakllsch · 2016-12-31T02:36:59Z

@jrtc27 It's very possible cabi_sparc64 is almost completely wrong, it's mostly a copy/paste of cabi_powerpc64 in #38656. However, it was enough to get a cross-compiled rustc to output its usage message on a NetBSD/sparc64 host. It did not succeed in actually compiling anything due to some unnaturally-aligned access faults, which I decided to postpone much investigation of while I got this upstreamed.

alexcrichton · 2016-12-31T02:45:54Z

This seems good to me, thanks @japaric!

I'm perpetually worried about all this cabi business though. It seems no one really knows what they're doing around the cabi modules and I'm reading "hello world works" as "someone's going to waste hours of their life later fixing an abi-related bug"

sanxiyn · 2017-01-01T05:54:38Z

@bors r+

bors · 2017-01-01T05:54:40Z

📌 Commit b14785d has been approved by sanxiyn

bors · 2017-01-01T07:50:11Z

⌛ Testing commit b14785d with merge a2930da...

bors · 2017-01-01T07:53:40Z

💔 Test failed - status-travis

sanxiyn · 2017-01-01T08:24:38Z

@bors retry

Network failure.

bors · 2017-01-01T09:56:03Z

⌛ Testing commit b14785d with merge e1279a0...

@alexcrichton

sparc64-linux support This is built on top of #38656 and depends on rust-lang/libc#483 Hello world works. The libc-test test suite passes. `panic!` doesn't fully work: ``` $ qemu-sparc64-static ./panic thread 'main' panicked at 'explicit panic', panic.rs:1 note: Run with `RUST_BACKTRACE=1` for a backtrace. Illegal instruction (core dumped) ``` Backtraces don't work either, probably related to the previous point: ``` $ export RUST_BACKTRACE=1 $ qemu-sparc64-static ./panic thread 'main' panicked at 'explicit panic', panic.rs:1 stack backtrace: Illegal instruction (core dumped) ``` r? @alexcrichton @jakllsch Does panicking / backtraces work on sparc64-netbsd? cc @glaubitz

bors · 2017-01-01T11:57:37Z

☀️ Test successful - status-appveyor, status-travis
Approved by: sanxiyn
Pushing e1279a0 to master...

Version 1.16.0 (2017-03-16) =========================== Language -------- * Lifetimes in statics and consts default to `'static`. [RFC 1623] * [The compiler's `dead_code` lint now accounts for type aliases][38051]. * [Uninhabitable enums (those without any variants) no longer permit wildcard match patterns][38069] * [Clean up semantics of `self` in an import list][38313] * [`Self` may appear in `impl` headers][38920] * [`Self` may appear in struct expressions][39282] Compiler -------- * [`rustc` now supports `--emit=metadata`, which causes rustc to emit a `.rmeta` file containing only crate metadata][38571]. This can be used by tools like the Rust Language Service to perform metadata-only builds. * [Levenshtein based typo suggestions now work in most places, while previously they worked only for fields and sometimes for local variables][38927]. Together with the overhaul of "no resolution"/"unexpected resolution" errors (#[38154]) they result in large and systematic improvement in resolution diagnostics. * [Fix `transmute::<T, U>` where `T` requires a bigger alignment than `U`][38670] * [rustc: use -Xlinker when specifying an rpath with ',' in it][38798] * [`rustc` no longer attempts to provide "consider using an explicit lifetime" suggestions][37057]. They were inaccurate. Stabilized APIs --------------- * [`VecDeque::truncate`] * [`VecDeque::resize`] * [`String::insert_str`] * [`Duration::checked_add`] * [`Duration::checked_sub`] * [`Duration::checked_div`] * [`Duration::checked_mul`] * [`str::replacen`] * [`str::repeat`] * [`SocketAddr::is_ipv4`] * [`SocketAddr::is_ipv6`] * [`IpAddr::is_ipv4`] * [`IpAddr::is_ipv6`] * [`Vec::dedup_by`] * [`Vec::dedup_by_key`] * [`Result::unwrap_or_default`] * [`<*const T>::wrapping_offset`] * [`<*mut T>::wrapping_offset`] * `CommandExt::creation_flags` * [`File::set_permissions`] * [`String::split_off`] Libraries --------- * [`[T]::binary_search` and `[T]::binary_search_by_key` now take their argument by `Borrow` parameter][37761] * [All public types in std implement `Debug`][38006] * [`IpAddr` implements `From<Ipv4Addr>` and `From<Ipv6Addr>`][38327] * [`Ipv6Addr` implements `From<[u16; 8]>`][38131] * [Ctrl-Z returns from `Stdin.read()` when reading from the console on Windows][38274] * [std: Fix partial writes in `LineWriter`][38062] * [std: Clamp max read/write sizes on Unix][38062] * [Use more specific panic message for `&str` slicing errors][38066] * [`TcpListener::set_only_v6` is deprecated][38304]. This functionality cannot be achieved in std currently. * [`writeln!`, like `println!`, now accepts a form with no string or formatting arguments, to just print a newline][38469] * [Implement `iter::Sum` and `iter::Product` for `Result`][38580] * [Reduce the size of static data in `std_unicode::tables`][38781] * [`char::EscapeDebug`, `EscapeDefault`, `EscapeUnicode`, `CaseMappingIter`, `ToLowercase`, `ToUppercase`, implement `Display`][38909] * [`Duration` implements `Sum`][38712] * [`String` implements `ToSocketAddrs`][39048] Cargo ----- * [The `cargo check` command does a type check of a project without building it][cargo/3296] * [crates.io will display CI badges from Travis and AppVeyor, if specified in Cargo.toml][cargo/3546] * [crates.io will display categories listed in Cargo.toml][cargo/3301] * [Compilation profiles accept integer values for `debug`, in addition to `true` and `false`. These are passed to `rustc` as the value to `-C debuginfo`][cargo/3534] * [Implement `cargo --version --verbose`][cargo/3604] * [All builds now output 'dep-info' build dependencies compatible with make and ninja][cargo/3557] * [Build all workspace members with `build --all`][cargo/3511] * [Document all workspace members with `doc --all`][cargo/3515] * [Path deps outside workspace are not members][cargo/3443] Misc ---- * [`rustdoc` has a `--sysroot` argument that, like `rustc`, specifies the path to the Rust implementation][38589] * [The `armv7-linux-androideabi` target no longer enables NEON extensions, per Google's ABI guide][38413] * [The stock standard library can be compiled for Redox OS][38401] * [Rust has initial SPARC support][38726]. Tier 3. No builds available. * [Rust has experimental support for Nvidia PTX][38559]. Tier 3. No builds available. * [Fix backtraces on i686-pc-windows-gnu by disabling FPO][39379] Compatibility Notes ------------------- * [Uninhabitable enums (those without any variants) no longer permit wildcard match patterns][38069] * In this release, references to uninhabited types can not be pattern-matched. This was accidentally allowed in 1.15. * [The compiler's `dead_code` lint now accounts for type aliases][38051]. * [Ctrl-Z returns from `Stdin.read()` when reading from the console on Windows][38274] * [Clean up semantics of `self` in an import list][38313] [37057]: rust-lang/rust#37057 [37761]: rust-lang/rust#37761 [38006]: rust-lang/rust#38006 [38051]: rust-lang/rust#38051 [38062]: rust-lang/rust#38062 [38062]: rust-lang/rust#38622 [38066]: rust-lang/rust#38066 [38069]: rust-lang/rust#38069 [38131]: rust-lang/rust#38131 [38154]: rust-lang/rust#38154 [38274]: rust-lang/rust#38274 [38304]: rust-lang/rust#38304 [38313]: rust-lang/rust#38313 [38314]: rust-lang/rust#38314 [38327]: rust-lang/rust#38327 [38401]: rust-lang/rust#38401 [38413]: rust-lang/rust#38413 [38469]: rust-lang/rust#38469 [38559]: rust-lang/rust#38559 [38571]: rust-lang/rust#38571 [38580]: rust-lang/rust#38580 [38589]: rust-lang/rust#38589 [38670]: rust-lang/rust#38670 [38712]: rust-lang/rust#38712 [38726]: rust-lang/rust#38726 [38781]: rust-lang/rust#38781 [38798]: rust-lang/rust#38798 [38909]: rust-lang/rust#38909 [38920]: rust-lang/rust#38920 [38927]: rust-lang/rust#38927 [39048]: rust-lang/rust#39048 [39282]: rust-lang/rust#39282 [39379]: rust-lang/rust#39379 [`<*const T>::wrapping_offset`]: https://doc.rust-lang.org/std/primitive.pointer.html#method.wrapping_offset [`<*mut T>::wrapping_offset`]: https://doc.rust-lang.org/std/primitive.pointer.html#method.wrapping_offset [`Duration::checked_add`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_add [`Duration::checked_div`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_div [`Duration::checked_mul`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_mul [`Duration::checked_sub`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_sub [`File::set_permissions`]: https://doc.rust-lang.org/std/fs/struct.File.html#method.set_permissions [`IpAddr::is_ipv4`]: https://doc.rust-lang.org/std/net/enum.IpAddr.html#method.is_ipv4 [`IpAddr::is_ipv6`]: https://doc.rust-lang.org/std/net/enum.IpAddr.html#method.is_ipv6 [`Result::unwrap_or_default`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.unwrap_or_default [`SocketAddr::is_ipv4`]: https://doc.rust-lang.org/std/net/enum.SocketAddr.html#method.is_ipv4 [`SocketAddr::is_ipv6`]: https://doc.rust-lang.org/std/net/enum.SocketAddr.html#method.is_ipv6 [`String::insert_str`]: https://doc.rust-lang.org/std/string/struct.String.html#method.insert_str [`String::split_off`]: https://doc.rust-lang.org/std/string/struct.String.html#method.split_off [`Vec::dedup_by_key`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.dedup_by_key [`Vec::dedup_by`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.dedup_by [`VecDeque::resize`]: https://doc.rust-lang.org/std/collections/vec_deque/struct.VecDeque.html#method.resize [`VecDeque::truncate`]: https://doc.rust-lang.org/std/collections/vec_deque/struct.VecDeque.html#method.truncate [`str::repeat`]: https://doc.rust-lang.org/std/primitive.str.html#method.repeat [`str::replacen`]: https://doc.rust-lang.org/std/primitive.str.html#method.replacen [cargo/3296]: rust-lang/cargo#3296 [cargo/3301]: rust-lang/cargo#3301 [cargo/3443]: rust-lang/cargo#3443 [cargo/3511]: rust-lang/cargo#3511 [cargo/3515]: rust-lang/cargo#3515 [cargo/3534]: rust-lang/cargo#3534 [cargo/3546]: rust-lang/cargo#3546 [cargo/3557]: rust-lang/cargo#3557 [cargo/3604]: rust-lang/cargo#3604 [RFC 1623]: https://github.com/rust-lang/rfcs/blob/master/text/1623-static.md

jakllsch and others added 8 commits December 29, 2016 21:30

further enable the Sparc LLVM backend

9828495

Add cabi_sparc64

011ebda

liballoc_*: add MIN_ALIGN for sparc64

5672c9b

libstd: define std::env::consts::ARCH for sparc64

eda889c

libunwind: unwinder_private_data_size for sparc64

ecd0ebb

libpanic_unwind: UNWIND_DATA_REG for sparc64

0751743

Add sparc64-unknown-netbsd target

8aef058

sparc64-linux support

728ec85

rust-highfive assigned alexcrichton Dec 31, 2016

Merge branch 'master' into sparc64

b14785d

bors merged commit b14785d into rust-lang:master Jan 1, 2017

This was referenced Jan 1, 2017

Ref suggestion #37658

Merged

[WIP] rustbuild: Build jemalloc and libbacktrace only once #38583

Closed

sanxiyn mentioned this pull request Jan 1, 2017

Add sparc64-unknown-netbsd target #38656

Closed

japaric deleted the sparc64 branch February 9, 2017 14:36

davidtwco mentioned this pull request Sep 20, 2023

target tier policy compliance #116004

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sparc64-linux support #38726

sparc64-linux support #38726

japaric commented Dec 31, 2016

rust-highfive commented Dec 31, 2016

glaubitz commented Dec 31, 2016

jrtc27 commented Dec 31, 2016 •

edited

Loading

jakllsch commented Dec 31, 2016

jakllsch commented Dec 31, 2016

alexcrichton commented Dec 31, 2016

sanxiyn commented Jan 1, 2017

bors commented Jan 1, 2017

bors commented Jan 1, 2017

bors commented Jan 1, 2017

sanxiyn commented Jan 1, 2017

bors commented Jan 1, 2017

bors commented Jan 1, 2017

sparc64-linux support #38726

sparc64-linux support #38726

Conversation

japaric commented Dec 31, 2016

rust-highfive commented Dec 31, 2016

glaubitz commented Dec 31, 2016

jrtc27 commented Dec 31, 2016 • edited Loading

jakllsch commented Dec 31, 2016

jakllsch commented Dec 31, 2016

alexcrichton commented Dec 31, 2016

sanxiyn commented Jan 1, 2017

bors commented Jan 1, 2017

bors commented Jan 1, 2017

bors commented Jan 1, 2017

sanxiyn commented Jan 1, 2017

bors commented Jan 1, 2017

bors commented Jan 1, 2017

jrtc27 commented Dec 31, 2016 •

edited

Loading