resolve: Suggest use self when import resolves
#36289
Conversation
Improves errors messages by replacing "Maybe a missing `extern crate`" messages with "Did you mean `self::...`" when the `self` import would succeed.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| Failed(Some((span, msg))) | ||
| }, | ||
| _ => Failed(err), | ||
| }; |
There was a problem hiding this comment.
optional nit: I think this match would look better as an if let (i.e. if let Success(_) = self_result { ... }).
|
@euclio Thanks for the PR! |
|
@bors r+ |
|
📌 Commit 288e7ca has been approved by |
|
⌛ Testing commit 288e7ca with merge 1f30d69... |
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors retry |
resolve: Suggest `use self` when import resolves Improves errors messages by replacing "Maybe a missing `extern crate`" messages with "Did you mean `self::...`" when the `self` import would succeed. Fixes #34191. Thank you for the help @jseyfried!
Improves errors messages by replacing "Maybe a missing
extern crate" messageswith "Did you mean
self::..." when theselfimport would succeed.Fixes #34191.
Thank you for the help @jseyfried!