Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rust-lldb warn about unsupported versions of LLDB #34646

Merged
merged 1 commit into from
Jul 5, 2016
Merged

Make rust-lldb warn about unsupported versions of LLDB #34646

merged 1 commit into from
Jul 5, 2016

Conversation

michaelwoerister
Copy link
Member

@alexcrichton
Copy link
Member

@bors: r+ dfe1217ea321a4b0a8e0cf20f6348978a01d796f

@bors
Copy link
Contributor

bors commented Jul 4, 2016

⌛ Testing commit dfe1217 with merge 6b04512...

@bors
Copy link
Contributor

bors commented Jul 4, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

aravind-pg
aravind-pg reviewed Jul 4, 2016
View reviewed changes
src/etc/rust-lldb
then
echo "***"
echo \
"WARNING: This version of LLDB has known issues with Rust and cannot not \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"cannot not"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks!

@michaelwoerister michaelwoerister force-pushed the warn-blacklisted-lldb branch from dfe1217 to 6be6289 Compare July 4, 2016 23:37
@michaelwoerister
Copy link
Member Author

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 4, 2016

📌 Commit 6be6289 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 5, 2016

⌛ Testing commit 6be6289 with merge 0f4c4f8...

bors added a commit that referenced this pull request Jul 5, 2016
@bors
Auto merge of #34646 - michaelwoerister:warn-blacklisted-lldb, r=alex…
0f4c4f8 
…crichton

Make rust-lldb warn about unsupported versions of LLDB

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jul 5, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit 6be6289 into rust-lang:master Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelwoerister @alexcrichton @bors @aravind-pg