Clarify documentation for string slicing (Index impls) #32099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ 3b0bbbc99d81b34d72256b2fa7f3daa04584a4cd rollup Thanks! |
| /// | ||
| /// Equivalent to `self[begin .. self.len()]`. | ||
| /// Returns a slice of the string from the beginning to byte offset |
There was a problem hiding this comment.
I think this should be "from byte offset begin to the end."
- Mention the sugared syntax for the implementations, since it's not apparent from the docs that `Index<Range<usize>>` corresponds to `&self[a..b]`. - Be specific in that start <= end and end <= len
bluss
force-pushed
the
doc-string-slicing
branch
from
3b0bbbc to
55671a0
Compare
|
@bors r=alexcrichton rollup I fixed the small mistakes. |
|
📌 Commit 55671a0 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Mar 8, 2016
…chton Clarify documentation for string slicing (Index impls) Clarify documentation for string slicing (Index impls) - Mention the sugared syntax for the implementations, since it's not apparent from the docs that `Index<Range<usize>>` corresponds to `&self[a..b]`. - Be specific in that start <= end and end <= len This is just one fix in response to rust-lang#32057
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Mar 8, 2016
…chton Clarify documentation for string slicing (Index impls) Clarify documentation for string slicing (Index impls) - Mention the sugared syntax for the implementations, since it's not apparent from the docs that `Index<Range<usize>>` corresponds to `&self[a..b]`. - Be specific in that start <= end and end <= len This is just one fix in response to rust-lang#32057
bors
added a commit
that referenced
this pull request
Mar 9, 2016
bluss
added a commit
to bluss/rust
that referenced
this pull request
Mar 10, 2016
This is a follow up for PR rust-lang#32099 and rust-lang#32057
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Mar 11, 2016
Clarify doc for slice slicing (Index impls) Clarify doc for slice slicing (Index impls) This is a follow up for PR rust-lang#32099 and rust-lang#32057
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 12, 2016
Clarify doc for slice slicing (Index impls) Clarify doc for slice slicing (Index impls) This is a follow up for PR rust-lang#32099 and rust-lang#32057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify documentation for string slicing (Index impls)
apparent from the docs that
Index<Range<usize>>corresponds to&self[a..b].This is just one fix in response to #32057