Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an impl for From trait #32050

Merged
merged 1 commit into from
Mar 19, 2016
Merged

Add an impl for From trait #32050

merged 1 commit into from
Mar 19, 2016

Conversation

achanda
Copy link
Contributor

@achanda achanda commented Mar 4, 2016

Converts a u8 slice to a Ipv4Addr
More discussion on this here: rust-lang/rfcs#1498 (comment)

@achanda
Copy link
Contributor Author

achanda commented Mar 4, 2016

r? @alexcrichton

@alexcrichton
Copy link
Member

Thanks! I'll tag this with T-libs to make sure we chat about this during triage, and we'll likely discuss it along with the RFC at the same time.

@alexcrichton alexcrichton self-assigned this Mar 5, 2016
@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 5, 2016
@sfackler
Copy link
Member

sfackler commented Mar 5, 2016

Could you add an explicit stability tag? It'll make it easier to tell in what release this impl was added.

@achanda
Copy link
Contributor Author

achanda commented Mar 5, 2016

@sfackler done!

Converts a u8 slice to a Ipv4Addr
@alexcrichton
Copy link
Member

The libs team discussed this yesterday and the decision was to merge!

@bors: r+ ee18d8e

@alexcrichton alexcrichton removed the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 17, 2016
@bors
Copy link
Contributor

bors commented Mar 17, 2016

⌛ Testing commit ee18d8e with merge ec733a3...

@bors
Copy link
Contributor

bors commented Mar 17, 2016

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Contributor

bors commented Mar 18, 2016

⌛ Testing commit ee18d8e with merge 941c514...

@bors
Copy link
Contributor

bors commented Mar 18, 2016

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Mar 17, 2016 at 11:52 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/8425


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#32050 (comment)

@bors
Copy link
Contributor

bors commented Mar 19, 2016

⌛ Testing commit ee18d8e with merge 50f96a7...

@alexcrichton
Copy link
Member

@bors: retry force clean

@bors
Copy link
Contributor

bors commented Mar 19, 2016

⌛ Testing commit ee18d8e with merge 10bdd80...

bors added a commit that referenced this pull request Mar 19, 2016
Add an impl for From trait

Converts a u8 slice to a Ipv4Addr
More discussion on this here: rust-lang/rfcs#1498 (comment)
@bors bors merged commit ee18d8e into rust-lang:master Mar 19, 2016
@achanda achanda deleted the from-slice-v4 branch March 19, 2016 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants