Fix various bugs around empty structs and patterns #29383

petrochenkov · 2015-10-26T18:19:10Z

Fixes #28692
Fixes #28992
Fixes some other similar issues (see the tests)

[breaking-change], needs crater run (cc @brson or @alexcrichton )

The pattern with parens UnitVariant(..) for unit variants seems to be popular in rustc (see the second commit), but mostly used by one person (@nikomatsakis), according to git blame. If it causes breakage on crates.io I'll add an exceptional case for it.

rust-highfive · 2015-10-26T18:19:22Z

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

nikomatsakis · 2015-10-26T18:29:43Z

Heh, yeah, I like to do Foo(..) if I only care about the variant, so that it is forwards compatible with adding parameters later (which happens pretty regularly).

pnkfelix · 2015-10-27T21:31:14Z

This PR looks fine to me. It does need a crater run.

(I have not yet successfully run crater but I'm wiling to give it another shot.)

bors · 2015-11-02T12:30:21Z

☔ The latest upstream changes (presumably #28846) made this pull request unmergeable. Please resolve the merge conflicts.

petrochenkov · 2015-11-02T13:30:11Z

Rebased.

pnkfelix · 2015-11-02T16:09:14Z

@petrochenkov great; I am seeing if I can do a crater run now with it.

alexcrichton · 2015-11-02T19:09:35Z

I've made a new needs-crater tag on GitHub so we can keep track of which PRs need a crater run so we know how to move them forward

bors · 2015-11-04T06:11:15Z

☔ The latest upstream changes (presumably #29217) made this pull request unmergeable. Please resolve the merge conflicts.

petrochenkov · 2015-11-04T13:32:08Z

Rebased.

bors · 2015-11-05T09:23:09Z

☔ The latest upstream changes (presumably #29581) made this pull request unmergeable. Please resolve the merge conflicts.

pnkfelix · 2015-11-05T10:15:45Z

@petrochenkov thanks for rebasing

pnkfelix · 2015-11-05T10:16:16Z

I did a crater run (on the revisions from before the rebase).

~~Zero regressions.~~

crater results here: https://gist.github.com/pnkfelix/4b800d1faf17eb494d8e

Update: I just looked at those results again, and realized that, if I understand them correctly, they are saying that all crates failed to build on both of my compilers. :(

I'm not quite sure what I did wrong, if anything. I'll try a new run on the rebased versions.

pnkfelix · 2015-11-05T10:16:47Z

~~(So, r=me after next rebase.)~~

Update: see above comment. The aforementioned crater run seemed problematic, not b/c of this PR, but probably user error.

petrochenkov · 2015-11-05T12:19:58Z

Rebased.

bors · 2015-11-11T18:36:18Z

☔ The latest upstream changes (presumably #29763) made this pull request unmergeable. Please resolve the merge conflicts.

petrochenkov · 2015-11-12T13:28:21Z

Rebased.

@alexcrichton, could you run crater on this?

alexcrichton · 2015-11-15T20:44:08Z

Starting a crater run.

bors · 2015-11-16T00:01:09Z

☔ The latest upstream changes (presumably #29387) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2015-11-16T03:56:44Z

Crater reports eight root regressions with as many as up to 34. I glanced at the root ones and they at least all look legitimate.

Perhaps that error could be a warning for a few cycles? Seems like a good bugfix to have, but may be good to give fair warning.

petrochenkov · 2015-11-19T09:24:51Z

Rebased.

petrochenkov · 2015-11-25T23:19:17Z

ping @pnkfelix
beta is soon

pnkfelix · 2015-11-27T20:42:44Z

@bors r+

bors · 2015-11-27T20:42:45Z

📌 Commit af96402 has been approved by pnkfelix

bors · 2015-11-28T00:16:08Z

⌛ Testing commit af96402 with merge f0fcef8...

bors · 2015-11-28T00:29:59Z

💔 Test failed - auto-mac-32-opt

petrochenkov · 2015-11-28T00:40:43Z

fatal: unable to connect to github.com:
github.com[0: 192.30.252.130]: errno=Operation timed out

Needs retry

bluss · 2015-11-28T00:45:33Z

@bors retry

bors · 2015-11-28T00:45:35Z

⌛ Testing commit af96402 with merge e9ac440...

@brson

Fixes #28692 Fixes #28992 Fixes some other similar issues (see the tests) [breaking-change], needs crater run (cc @brson or @alexcrichton ) The pattern with parens `UnitVariant(..)` for unit variants seems to be popular in rustc (see the second commit), but mostly used by one person (@nikomatsakis), according to git blame. If it causes breakage on crates.io I'll add an exceptional case for it.

bors · 2015-11-28T03:05:22Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

bluss · 2015-11-30T14:53:17Z

It looks like it's a breaking change anyway, conv ~~0.3.1~~ 0.3.0 + git

src/errors.rs:576:17: 576:32 warning: `NegOverflow` does not name a tuple variant or a tuple struct [E0164]
src/errors.rs:576             Err(NegOverflow(..)) => T::neg_infinity(),
                                  ^~~~~~~~~~~~~~~
src/errors.rs:576:17: 576:32 help: run `rustc --explain E0164` to see a detailed explanation
src/errors.rs:576:17: 576:32 note: this warning will become a HARD ERROR in a future release. See RFC 218 for det
ails.
src/errors.rs:576             Err(NegOverflow(..)) => T::neg_infinity(),
                                  ^~~~~~~~~~~~~~~
src/errors.rs:577:17: 577:32 warning: `PosOverflow` does not name a tuple variant or a tuple struct [E0164]
src/errors.rs:577             Err(PosOverflow(..)) => T::pos_infinity(),
                                  ^~~~~~~~~~~~~~~
src/errors.rs:577:17: 577:32 help: run `rustc --explain E0164` to see a detailed explanation
src/errors.rs:577:17: 577:32 note: this warning will become a HARD ERROR in a future release. See RFC 218 for details.
src/errors.rs:577             Err(PosOverflow(..)) => T::pos_infinity(),
                                  ^~~~~~~~~~~~~~~
src/errors.rs:602:17: 602:32 warning: `NegOverflow` does not name a tuple variant or a tuple struct [E0164]
src/errors.rs:602             Err(NegOverflow(..)) => T::saturated_min(),
                                  ^~~~~~~~~~~~~~~
src/errors.rs:602:17: 602:32 help: run `rustc --explain E0164` to see a detailed explanation
src/errors.rs:602:17: 602:32 note: this warning will become a HARD ERROR in a future release. See RFC 218 for details.
src/errors.rs:602             Err(NegOverflow(..)) => T::saturated_min(),
                                  ^~~~~~~~~~~~~~~
src/errors.rs:603:17: 603:32 warning: `PosOverflow` does not name a tuple variant or a tuple struct [E0164]
src/errors.rs:603             Err(PosOverflow(..)) => T::saturated_max(),
                                  ^~~~~~~~~~~~~~~
src/errors.rs:603:17: 603:32 help: run `rustc --explain E0164` to see a detailed explanation
src/errors.rs:603:17: 603:32 note: this warning will become a HARD ERROR in a future release. See RFC 218 for details.
src/errors.rs:603             Err(PosOverflow(..)) => T::saturated_max(),
                                  ^~~~~~~~~~~~~~~
src/errors.rs:574:9: 578:10 error: non-exhaustive patterns: `Err(_)` not covered [E0004]
src/errors.rs:574         match self.map_err(Into::into) {
src/errors.rs:575             Ok(v) => v,
src/errors.rs:576             Err(NegOverflow(..)) => T::neg_infinity(),
src/errors.rs:577             Err(PosOverflow(..)) => T::pos_infinity(),
src/errors.rs:578         }
src/errors.rs:574:9: 578:10 help: run `rustc --explain E0004` to see a detailed explanation
src/errors.rs:600:9: 604:10 error: non-exhaustive patterns: `Err(_)` not covered [E0004]
src/errors.rs:600         match self.map_err(Into::into) {
src/errors.rs:601             Ok(v) => v,
src/errors.rs:602             Err(NegOverflow(..)) => T::saturated_min(),
src/errors.rs:603             Err(PosOverflow(..)) => T::saturated_max(),
src/errors.rs:604         }

…structs See rust-lang/rust#29383 for the breaking change.

petrochenkov · 2015-11-30T15:55:19Z

Hm, the warning should not affect exhaustiveness check, I'll investigate what happens.

bluss · 2015-11-30T16:09:40Z

I apologise if I'm pointing to the wrong PR, but it seems related.

@bluss

Fixes #29383 (comment) r? @bluss

…rors, r=nikomatsakis Downgrade unit struct match via S(..) warnings to errors The error signalling was introduced in #29383 It was noted as a warning-cycle-less regression in #30379 Fix #30379

rust-highfive assigned pnkfelix Oct 26, 2015

petrochenkov force-pushed the empstr branch from 040ad0f to 40717ca Compare November 2, 2015 13:29

alexcrichton added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 2, 2015

petrochenkov force-pushed the empstr branch from 40717ca to b7f8311 Compare November 4, 2015 13:31

petrochenkov mentioned this pull request Nov 4, 2015

Cannot derive Clone when using 'braced_empty_structs' #29548

Closed

pnkfelix removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 5, 2015

pnkfelix added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 5, 2015

petrochenkov force-pushed the empstr branch from b7f8311 to fec3902 Compare November 5, 2015 12:19

petrochenkov mentioned this pull request Nov 10, 2015

Tracking issue for braced_empty_structs (RFC 218) #29720

Closed

petrochenkov force-pushed the empstr branch from fec3902 to 9942e4e Compare November 12, 2015 13:27

alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 16, 2015

petrochenkov added 3 commits November 19, 2015 11:41

Fix the fallout

3574992

Add special case for UnitVariant(..) patterns

4573bb8

Add a future compatibility note

af96402

petrochenkov force-pushed the empstr branch from afe9350 to af96402 Compare November 19, 2015 09:24

bors merged commit af96402 into rust-lang:master Nov 28, 2015

m4rw3r added a commit to m4rw3r/rust-conv that referenced this pull request Nov 30, 2015

Nightly 2015-11-30: Fix for non-exhaustive patterns when using empty …

3d48675

…structs See rust-lang/rust#29383 for the breaking change.

m4rw3r mentioned this pull request Nov 30, 2015

Nightly 2015-11-30: Fix for non-exhaustive patterns when using empty structs DanielKeep/rust-conv#4

Merged

petrochenkov mentioned this pull request Nov 30, 2015

Fix nightly regression in patterns with empty variants #30116

Merged

bors added a commit that referenced this pull request Dec 1, 2015

Auto merge of #30116 - petrochenkov:exhaust, r=alexcrichton

c212c0e

Fixes #29383 (comment) r? @bluss

petrochenkov mentioned this pull request Dec 14, 2015

beta regression matching unit-like structs with .. #30379

Closed

pnkfelix mentioned this pull request Jan 7, 2016

Downgrade unit struct match via S(..) warnings to errors #30753

Merged

petrochenkov deleted the empstr branch September 21, 2016 19:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix various bugs around empty structs and patterns #29383

Fix various bugs around empty structs and patterns #29383

petrochenkov commented Oct 26, 2015

rust-highfive commented Oct 26, 2015

nikomatsakis commented Oct 26, 2015

pnkfelix commented Oct 27, 2015

bors commented Nov 2, 2015

petrochenkov commented Nov 2, 2015

pnkfelix commented Nov 2, 2015

alexcrichton commented Nov 2, 2015

bors commented Nov 4, 2015

petrochenkov commented Nov 4, 2015

bors commented Nov 5, 2015

pnkfelix commented Nov 5, 2015

pnkfelix commented Nov 5, 2015

pnkfelix commented Nov 5, 2015

petrochenkov commented Nov 5, 2015

bors commented Nov 11, 2015

petrochenkov commented Nov 12, 2015

alexcrichton commented Nov 15, 2015

bors commented Nov 16, 2015

alexcrichton commented Nov 16, 2015

petrochenkov commented Nov 19, 2015

petrochenkov commented Nov 25, 2015

pnkfelix commented Nov 27, 2015

bors commented Nov 27, 2015

bors commented Nov 28, 2015

bors commented Nov 28, 2015

petrochenkov commented Nov 28, 2015

bluss commented Nov 28, 2015

bors commented Nov 28, 2015

bors commented Nov 28, 2015

bluss commented Nov 30, 2015

petrochenkov commented Nov 30, 2015

bluss commented Nov 30, 2015

Fix various bugs around empty structs and patterns #29383

Fix various bugs around empty structs and patterns #29383

Conversation

petrochenkov commented Oct 26, 2015

rust-highfive commented Oct 26, 2015

nikomatsakis commented Oct 26, 2015

pnkfelix commented Oct 27, 2015

bors commented Nov 2, 2015

petrochenkov commented Nov 2, 2015

pnkfelix commented Nov 2, 2015

alexcrichton commented Nov 2, 2015

bors commented Nov 4, 2015

petrochenkov commented Nov 4, 2015

bors commented Nov 5, 2015

pnkfelix commented Nov 5, 2015

pnkfelix commented Nov 5, 2015

pnkfelix commented Nov 5, 2015

petrochenkov commented Nov 5, 2015

bors commented Nov 11, 2015

petrochenkov commented Nov 12, 2015

alexcrichton commented Nov 15, 2015

bors commented Nov 16, 2015

alexcrichton commented Nov 16, 2015

petrochenkov commented Nov 19, 2015

petrochenkov commented Nov 25, 2015

pnkfelix commented Nov 27, 2015

bors commented Nov 27, 2015

bors commented Nov 28, 2015

bors commented Nov 28, 2015

petrochenkov commented Nov 28, 2015

bluss commented Nov 28, 2015

bors commented Nov 28, 2015

bors commented Nov 28, 2015

bluss commented Nov 30, 2015

petrochenkov commented Nov 30, 2015

bluss commented Nov 30, 2015