Implement a few methods for RingBuf #20197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
pczarn
force-pushed
the
ring_buf-collections-reform
branch
from
0646db8 to
13be65b
Compare
| /// It will drop down as close as possible to the length but the allocator may still inform the | ||
| /// vector that there is space for a few more elements. | ||
| /// | ||
| /// Returns `None` if `index` is out of bounds. |
There was a problem hiding this comment.
This function does not seem to return anything judging by its type notation.
pczarn
force-pushed
the
ring_buf-collections-reform
branch
from
13be65b to
8c3436e
Compare
| /// # Examples | ||
| /// | ||
| /// ``` | ||
| /// let mut vec = vec![1i, 2, 3, 4]; |
|
Done review. |
pczarn
force-pushed
the
ring_buf-collections-reform
branch
from
c6c6946 to
e0c06b7
Compare
|
@pczarn I see you've added some commits; is that everything or are you still working on it (basically: should I re-review now?) |
|
@gankro that's everything, except for swap_.._remove tests; hope to add them now. |
| self.cap); | ||
| ptr::copy_nonoverlapping_memory( | ||
| self.ptr.offset(dst as int), | ||
| self.ptr.offset(src as int) as *const T, |
There was a problem hiding this comment.
I think the as *const T should just coerce for free? Still trying to grok when these coercions do or don't kick in, though.
|
Okay lgtm modulo nits/tests. |
pczarn
force-pushed
the
ring_buf-collections-reform
branch
3 times, most recently
from
603fadd to
f47dd53
Compare
pczarn
force-pushed
the
ring_buf-collections-reform
branch
from
f47dd53 to
00f8cdf
Compare
|
r=me with squash |
pczarn
force-pushed
the
ring_buf-collections-reform
branch
2 times, most recently
from
b216a09 to
841b458
Compare
|
@gankro, done. |
* shrink_to_fit * swap_back_remove * swap_front_remove * truncate * resize
pczarn
force-pushed
the
ring_buf-collections-reform
branch
from
841b458 to
156a1c3
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 6, 2015
Part of collections reform part 1 and 2, rust-lang#18424 and rust-lang#19986 * shrink_to_fit * swap_back_remove * swap_front_remove * truncate * resize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of collections reform part 1 and 2, #18424 and #19986