Enable unreachable_pub
lint in core
#134286
Open
+140
−129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
unreachable_pub
as warn incore
,rtstartup
andpanic_unwind
.The motivation is similar to the compiler MCP: Enable deny(unreachable_pub) on
rustc_*
crates :Another motivation is to help to lint by utilizing it in-tree and seeing it's limitation in more complex scenarios.
The diff was mostly generated with
./x.py fix --stage 1 library/core/ -- --broken-code
, as well as manual edits for code in macros, generated code and other targets.r? libs