Small doc fixes in rustc_codegen_ssa
#133557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use intra-doc links so there'll be a doc gen fail next time this becomes wrong
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
|
cc @bjorn3 as you may know if this description is accurate or not. |
|
r? @bjorn3 |
|
Thanks! @bors r+ rollup=always |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#133358 (Don't type error if we fail to coerce `Pin<T>` because it doesnt contain a ref) - rust-lang#133422 (Fix clobber_abi in RV32E and RV64E inline assembly) - rust-lang#133452 (Support predicate registers (clobber-only) in Hexagon inline assembly) - rust-lang#133463 (Fix handling of x18 in AArch64 inline assembly on ohos/trusty or with -Zfixed-x18) - rust-lang#133487 (fix confusing diagnostic for reserved `##`) - rust-lang#133557 (Small doc fixes in `rustc_codegen_ssa`) - rust-lang#133560 (Trim extra space in 'repeated `mut`' diagnostic) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2024
Rollup merge of rust-lang#133557 - Monadic-Cat:small_doc_fixes, r=bjorn3 Small doc fixes in `rustc_codegen_ssa` I'm trying to make a toy codegen backend for `rustc`, and I got confused for a few minutes about what `codegen_backend` was referring to in the `CodegenBackend::join_codegen` docs. Experimentally, it looks like the result of `CodegenBackend::codegen_crate` is passed to `CodegenBackend::join_codegen`, so this updates the docs to refer to that. This time using intra-doc links to hopefully cause people to notice if that gets out of date again. Also, added another intra-doc link nearby, on `CodegenBackend::link`, for the same reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to make a toy codegen backend for
rustc, and I got confused for a few minutes about whatcodegen_backendwas referring to in theCodegenBackend::join_codegendocs.Experimentally, it looks like the result of
CodegenBackend::codegen_crateis passed toCodegenBackend::join_codegen, so this updates the docs to refer to that. This time using intra-doc links to hopefully cause people to notice if that gets out of date again.Also, added another intra-doc link nearby, on
CodegenBackend::link, for the same reason.