Rollup of 5 pull requests #133234

jhpratt · 2024-11-20T06:54:28Z

Successful merges:

Use attributes for dangling_pointers_from_temporaries lint #132732 (Use attributes for dangling_pointers_from_temporaries lint)
lints_that_dont_need_to_run: never skip future-compat-reported lints #133108 (lints_that_dont_need_to_run: never skip future-compat-reported lints)
CI: use free runner in dist-aarch64-msvc #133190 (CI: use free runner in dist-aarch64-msvc)
Make rustc --explain compatible with BusyBox less #133196 (Make rustc --explain compatible with BusyBox less)
Implement ~const Fn trait goal in the new solver #133216 (Implement ~const Fn trait goal in the new solver)

r? @ghost
@rustbot modify labels: rollup

… names Co-authored-by: Urgau <[email protected]>

busybox less does not support the -r flag and less(1) says: USE OF THE -r OPTION IS NOT RECOMMENDED.

…Urgau Use attributes for `dangling_pointers_from_temporaries` lint Checking for dangling pointers by function name isn't ideal, and leaves out certain pointer-returning methods that don't follow the `as_ptr` naming convention. Using an attribute for this lint cleans things up and allows more thorough coverage of other methods, such as `UnsafeCell::get()`.

…n, r=lcnr lints_that_dont_need_to_run: never skip future-compat-reported lints Follow-up to rust-lang#125116: future-compat lints show up with `--json=future-incompat` even if they are otherwise allowed in the crate. So let's ensure we do not skip those as part of the `lints_that_dont_need_to_run` logic. I could not find a current future compat lint that is emitted by a lint pass, so there's no clear way to add a test for this. Cc `@blyxyas` `@cjgillot`

…r=Kobzol CI: use free runner in dist-aarch64-msvc try-job: dist-aarch64-msvc

…tgross35 Make rustc --explain compatible with BusyBox less busybox less does not support the -r flag and less(1) says: USE OF THE -r OPTION IS NOT RECOMMENDED.

Implement `~const Fn` trait goal in the new solver Split out from rust-lang#132329 since this should be easier to review on its own. r? lcnr

jhpratt · 2024-11-20T06:54:37Z

@bors r+ rollup=never p=5

bors · 2024-11-20T06:54:39Z

📌 Commit b9cd5eb has been approved by jhpratt

It is now in the queue for this repository.

bors · 2024-11-20T09:27:59Z

⌛ Testing commit b9cd5eb with merge fda6892...

bors · 2024-11-20T12:31:48Z

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing fda6892 to master...

rust-timer · 2024-11-20T12:33:16Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#132732	Use attributes for `dangling_pointers_from_temporaries` lint	`0f0ea1170a9d1a2db1ae3684c1648810fe870814` (link)
#133108	lints_that_dont_need_to_run: never skip future-compat-repor…	`4c3b9781a02efb538dc3f3f86cb38dc85f0f1221` (link)
#133190	CI: use free runner in dist-aarch64-msvc	`c4716dae6f21ef551d0b2277c7eff416294533a7` (link)
#133196	Make rustc --explain compatible with BusyBox less	`1090d3ac145cbce824042a6a1cfbbb827412dfc2` (link)
#133216	Implement `~const Fn` trait goal in the new solver	`0a493a4daa0c340cd629567a22d5c418cc1c1861` (link)

previous master: 70e814bd9e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-11-20T13:51:03Z

Finished benchmarking commit (fda6892): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	2.2%	[0.2%, 5.5%]	8
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.9%	[-5.9%, -5.9%]	1
All ❌✅ (primary)	2.2%	[0.2%, 5.5%]	8

Max RSS (memory usage)

Results (primary 1.2%, secondary -0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[1.2%, 1.3%]	2
Regressions ❌ (secondary)	3.7%	[3.7%, 3.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.9%	[-4.9%, -4.9%]	1
All ❌✅ (primary)	1.2%	[1.2%, 1.3%]	2

Cycles

Results (primary 3.7%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[1.2%, 5.0%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.5%, -2.0%]	4
All ❌✅ (primary)	3.7%	[1.2%, 5.0%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 793.177s -> 795.539s (0.30%)
Artifact size: 335.96 MiB -> 335.98 MiB (0.01%)

lqd · 2024-11-20T14:05:29Z

This looks related to lints so let's start with @rust-timer build 0f0ea11

rust-timer · 2024-11-20T16:24:06Z

Finished benchmarking commit (0f0ea11): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	2.2%	[0.2%, 5.5%]	8
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.4%	[-5.4%, -5.4%]	1
All ❌✅ (primary)	2.2%	[0.2%, 5.5%]	8

Max RSS (memory usage)

Results (primary 1.7%, secondary 3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.2%, 2.5%]	3
Regressions ❌ (secondary)	3.7%	[3.7%, 3.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.7%	[1.2%, 2.5%]	3

Cycles

Results (primary 4.6%, secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.6%	[4.3%, 5.0%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.2%, -2.1%]	2
All ❌✅ (primary)	4.6%	[4.3%, 5.0%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 793.177s -> 794.793s (0.20%)
Artifact size: 335.96 MiB -> 335.97 MiB (0.00%)

lqd · 2024-11-20T16:32:31Z

That was indeed #132732

Kobzol · 2024-11-26T08:35:10Z

Following the discussion about the perf. regression here. Not marking as triaged.

gavincrawford and others added 15 commits November 11, 2024 13:33

Add #[rustc_as_ptr] attribute

5f443df

Check for #[rustc_as_ptr] attribute instead of searching for function…

37c30ae

… names Co-authored-by: Urgau <[email protected]>

Tag relevant functions with #[rustc_as_ptr] attribute

fdef65b

Update dangling pointer tests

8ec94d3

Remove as_mut_ptr symbol

24cc924

Make rustc --explain busybox less compatible

6f8fe79

busybox less does not support the -r flag and less(1) says: USE OF THE -r OPTION IS NOT RECOMMENDED.

CI: use free runner in dist-aarch64-msvc

0270580

Correct comments concerning updated dangling pointer lint

01fd384

lints_that_dont_need_to_run: never skip future-compat-reported lints

df94818

Implement ~const Fn trait goals in the new solver

def7ed0

Rollup merge of rust-lang#133190 - MarcoIeni:dist-aarch64-msvc-free, …

c364ff7

…r=Kobzol CI: use free runner in dist-aarch64-msvc try-job: dist-aarch64-msvc

Rollup merge of rust-lang#133196 - omnivagant:correct-less-r-flag, r=…

cd36973

…tgross35 Make rustc --explain compatible with BusyBox less busybox less does not support the -r flag and less(1) says: USE OF THE -r OPTION IS NOT RECOMMENDED.

Rollup merge of rust-lang#133216 - compiler-errors:const-fn, r=lcnr

b9cd5eb

Implement `~const Fn` trait goal in the new solver Split out from rust-lang#132329 since this should be easier to review on its own. r? lcnr

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 20, 2024

bors merged commit fda6892 into rust-lang:master Nov 20, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Nov 20, 2024

This was referenced Nov 20, 2024

Implement ~const Destruct effect goal in the new solver #132329

Merged

Rewrite show_md_content_with_pager #133228

Merged

rustbot added the perf-regression Performance regression. label Nov 20, 2024

This comment has been minimized.

Sign in to view

Kobzol mentioned this pull request Nov 26, 2024

Use attributes for dangling_pointers_from_temporaries lint #132732

Merged

jhpratt deleted the rollup-42dmg4p branch November 26, 2024 08:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #133234

Rollup of 5 pull requests #133234

jhpratt commented Nov 20, 2024

jhpratt commented Nov 20, 2024

bors commented Nov 20, 2024

bors commented Nov 20, 2024

bors commented Nov 20, 2024

rust-timer commented Nov 20, 2024

rust-timer commented Nov 20, 2024

lqd commented Nov 20, 2024

This comment has been minimized.

rust-timer commented Nov 20, 2024

lqd commented Nov 20, 2024

Kobzol commented Nov 26, 2024

Rollup of 5 pull requests #133234

Rollup of 5 pull requests #133234

Conversation

jhpratt commented Nov 20, 2024

jhpratt commented Nov 20, 2024

bors commented Nov 20, 2024

bors commented Nov 20, 2024

bors commented Nov 20, 2024

rust-timer commented Nov 20, 2024

rust-timer commented Nov 20, 2024

Overall result: ❌✅ regressions and improvements - please read the text below

lqd commented Nov 20, 2024

This comment has been minimized.

rust-timer commented Nov 20, 2024

Overall result: ❌✅ regressions and improvements - please read the text below

lqd commented Nov 20, 2024

Kobzol commented Nov 26, 2024