Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For expr return (_ = 42); unused_paren lint should not be triggered #132936

Merged
merged 2 commits into from
Nov 16, 2024
Merged

For expr return (_ = 42); unused_paren lint should not be triggered #132936

merged 2 commits into from
Nov 16, 2024

Conversation

surechen
Copy link
Contributor

fixes #131989

@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2024
@Nadrieril
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2024
@surechen surechen requested a review from Nadrieril November 14, 2024 02:19
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 14, 2024
@Nadrieril
Copy link
Member

Looks good, thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2024

📌 Commit 3a74bce has been approved by Nadrieril

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 15, 2024
@matthiaskrgr
Rollup merge of rust-lang#132936 - surechen:fix_131989, r=Nadrieril
18b44af 
For expr `return (_ = 42);` unused_paren lint should not be triggered

fixes rust-lang#131989
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 15, 2024
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 15, 2024
@GuillaumeGomez
Rollup merge of rust-lang#132936 - surechen:fix_131989, r=Nadrieril
3bd2f57 
For expr `return (_ = 42);` unused_paren lint should not be triggered

fixes rust-lang#131989
This was referenced Nov 15, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
@bors
Auto merge of rust-lang#133086 - GuillaumeGomez:rollup-kbkfrkj, r=Gui…
d3a4b1f 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#132936 (For expr `return (_ = 42);` unused_paren lint should not be triggered)
 - rust-lang#132956 (Add visit_coroutine_kind to ast::Visitor)
 - rust-lang#132978 (Mention both release *and* edition breakage for never type lints)
 - rust-lang#133074 (make UI test OS-agnostic)
 - rust-lang#133080 (Fix span edition for 2024 RPIT coming from an external macro )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1f83a4d into rust-lang:master Nov 16, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2024
@rust-timer
Unrolled build for rust-lang#132936
cd03af9 
Rollup merge of rust-lang#132936 - surechen:fix_131989, r=Nadrieril

For expr `return (_ = 42);` unused_paren lint should not be triggered

fixes rust-lang#131989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadrieril Nadrieril Awaiting requested review from Nadrieril

Assignees

@Nadrieril Nadrieril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.

False positive for unused_parens in a return
4 participants
@surechen @rustbot @Nadrieril @bors