Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --diagnostic-width to some tests failing after 1a0c5021838 #132707

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

zmodem
Copy link
Contributor

@zmodem zmodem commented Nov 6, 2024

Otherwise the tests would fail depending on the execution environment.

Otherwise the tests would fail depending on the execution environment.
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2024
@zmodem
Copy link
Contributor Author

zmodem commented Nov 6, 2024

r? @durin42

@rustbot rustbot assigned durin42 and unassigned petrochenkov Nov 6, 2024
@zmodem
Copy link
Contributor Author

zmodem commented Nov 6, 2024

@rustbot label llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Nov 6, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Nov 7, 2024

This is not llvm specific so @rustbot label -llvm-main

Thanks!

r? jieyouxu @bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 7, 2024

📌 Commit 029add2 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot removed the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Nov 7, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Nov 7, 2024

Oh wait is this needed by upstream, nevermind

@rustbot label +llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Nov 7, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2024
Rollup of 6 pull requests

Successful merges:

 - rust-lang#132057 (miri: update ABI compat checks to accept Option-like types)
 - rust-lang#132665 (Implement `div_ceil` for `NonZero<unsigned>`)
 - rust-lang#132694 (fix(x): fix a regex used to find python executable)
 - rust-lang#132707 (Add --diagnostic-width to some tests failing after 1a0c502)
 - rust-lang#132715 (fix `LazyLock::get` and `LazyLock::get_mut` document)
 - rust-lang#132716 (chore(issue-template): fix branch name)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 59582fb into rust-lang:master Nov 7, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2024
Rollup merge of rust-lang#132707 - zmodem:tests_vs_diagnostic_width, r=jieyouxu

Add --diagnostic-width to some tests failing after 1a0c502

Otherwise the tests would fail depending on the execution environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants