Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port run-make/libtest-json and run-make/libtest-junit to rmake #129037

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Port run-make/libtest-json and run-make/libtest-junit to rmake #129037

merged 2 commits into from
Aug 16, 2024

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Aug 13, 2024 •
edited by jieyouxu
Loading

Unlike #126773, this is just a straightforward port to rmake, without attempting to switch to compiletest or get rid of the (trivial) Python scripts.

Part of #121876.

r? @jieyouxu

try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
try-job: aarch64-gnu
try-job: aarch64-apple

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 13, 2024
@Zalathar Zalathar changed the title Port run-make/libtest-json and run-make/libtest-junit to rmake Port run-make/libtest-json and run-make/libtest-junit to rmake Aug 13, 2024
@Zalathar Zalathar mentioned this pull request Aug 13, 2024
Closed
@jieyouxu
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented Aug 13, 2024

⌛ Trying commit fc733a6 with merge 6359654...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 13, 2024
@bors
Auto merge of rust-lang#129037 - Zalathar:rmake-libtest, r=<try>
6359654 
Port `run-make/libtest-json` and `run-make/libtest-junit` to rmake

Unlike rust-lang#126773, this is just a straightforward port to `rmake`, without attempting to switch to compiletest or get rid of the (trivial) Python scripts.

Part of rust-lang#121876.

r? `@jieyouxu`

try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
try-job: aarch64-gnu
try-job: aarch64-apple
@Kobzol Kobzol mentioned this pull request Aug 13, 2024
Open
@bors
Copy link
Contributor

bors commented Aug 13, 2024

☀️ Try build successful - checks-actions
Build commit: 6359654 (6359654b58fd4c510b847f5d6de715170a5d74a4)

jieyouxu
jieyouxu approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This LGTM.

@jieyouxu
Copy link
Member

@bors r+ rollup=iffy (exercises python scripts)

@bors
Copy link
Contributor

bors commented Aug 14, 2024

📌 Commit fc733a6 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 15, 2024
@matthiaskrgr
Rollup merge of rust-lang#129037 - Zalathar:rmake-libtest, r=jieyouxu
13b3a96 
Port `run-make/libtest-json` and `run-make/libtest-junit` to rmake

Unlike rust-lang#126773, this is just a straightforward port to `rmake`, without attempting to switch to compiletest or get rid of the (trivial) Python scripts.

Part of rust-lang#121876.

r? `@jieyouxu`

try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
try-job: aarch64-gnu
try-job: aarch64-apple
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 15, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Aug 16, 2024
@workingjubilee
Rollup merge of rust-lang#129037 - Zalathar:rmake-libtest, r=jieyouxu
48af62f 
Port `run-make/libtest-json` and `run-make/libtest-junit` to rmake

Unlike rust-lang#126773, this is just a straightforward port to `rmake`, without attempting to switch to compiletest or get rid of the (trivial) Python scripts.

Part of rust-lang#121876.

r? `@jieyouxu`

try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
try-job: aarch64-gnu
try-job: aarch64-apple
@workingjubilee workingjubilee mentioned this pull request Aug 16, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Aug 16, 2024
@workingjubilee
Rollup merge of rust-lang#129037 - Zalathar:rmake-libtest, r=jieyouxu
8fd4899 
Port `run-make/libtest-json` and `run-make/libtest-junit` to rmake

Unlike rust-lang#126773, this is just a straightforward port to `rmake`, without attempting to switch to compiletest or get rid of the (trivial) Python scripts.

Part of rust-lang#121876.

r? ``@jieyouxu``

try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
try-job: aarch64-gnu
try-job: aarch64-apple
@workingjubilee workingjubilee mentioned this pull request Aug 16, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Aug 16, 2024
@workingjubilee
Rollup merge of rust-lang#129037 - Zalathar:rmake-libtest, r=jieyouxu
c2b6a7e 
Port `run-make/libtest-json` and `run-make/libtest-junit` to rmake

Unlike rust-lang#126773, this is just a straightforward port to `rmake`, without attempting to switch to compiletest or get rid of the (trivial) Python scripts.

Part of rust-lang#121876.

r? ```@jieyouxu```

try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
try-job: aarch64-gnu
try-job: aarch64-apple
@workingjubilee workingjubilee mentioned this pull request Aug 16, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2024
@bors
Auto merge of rust-lang#129142 - workingjubilee:rollup-7sspo84, r=wor…
0ab0b0b 
…kingjubilee

Rollup of 10 pull requests

Successful merges:

 - rust-lang#128064 (Improve docs for Waker::noop and LocalWaker::noop)
 - rust-lang#128922 (rust-analyzer: use in-tree `pattern_analysis` crate)
 - rust-lang#128965 (Remove `print::Pat` from the printing of `WitnessPat`)
 - rust-lang#128977 (Only try to modify file times of a writable file on Windows)
 - rust-lang#129018 (Migrate `rlib-format-packed-bundled-libs` and `native-link-modifier-bundle` `run-make` tests to rmake)
 - rust-lang#129037 (Port `run-make/libtest-json` and `run-make/libtest-junit` to rmake)
 - rust-lang#129078 (`ParamEnvAnd::fully_perform`: we have an `ocx`, use it)
 - rust-lang#129110 (Add a comment explaining the return type of `Ty::kind`.)
 - rust-lang#129111 (Port the `sysroot-crates-are-unstable` Python script to rmake)
 - rust-lang#129135 (crashes: more tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Aug 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2024
@bors
Auto merge of rust-lang#129143 - workingjubilee:rollup-h0hzumu, r=wor…
69e36d6 
…kingjubilee

Rollup of 9 pull requests

Successful merges:

 - rust-lang#128064 (Improve docs for Waker::noop and LocalWaker::noop)
 - rust-lang#128922 (rust-analyzer: use in-tree `pattern_analysis` crate)
 - rust-lang#128965 (Remove `print::Pat` from the printing of `WitnessPat`)
 - rust-lang#129018 (Migrate `rlib-format-packed-bundled-libs` and `native-link-modifier-bundle` `run-make` tests to rmake)
 - rust-lang#129037 (Port `run-make/libtest-json` and `run-make/libtest-junit` to rmake)
 - rust-lang#129078 (`ParamEnvAnd::fully_perform`: we have an `ocx`, use it)
 - rust-lang#129110 (Add a comment explaining the return type of `Ty::kind`.)
 - rust-lang#129111 (Port the `sysroot-crates-are-unstable` Python script to rmake)
 - rust-lang#129135 (crashes: more tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eb6ecf1 into rust-lang:master Aug 16, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2024
@rust-timer
Unrolled build for rust-lang#129037
a22adfc 
Rollup merge of rust-lang#129037 - Zalathar:rmake-libtest, r=jieyouxu

Port `run-make/libtest-json` and `run-make/libtest-junit` to rmake

Unlike rust-lang#126773, this is just a straightforward port to `rmake`, without attempting to switch to compiletest or get rid of the (trivial) Python scripts.

Part of rust-lang#121876.

r? ````@jieyouxu````

try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
try-job: aarch64-gnu
try-job: aarch64-apple
@Zalathar Zalathar deleted the rmake-libtest branch August 16, 2024 07:48
@Zalathar Zalathar mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Zalathar @rustbot @rust-log-analyzer @jieyouxu @bors