Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured suggestion for extern crate foo when foo isn't resolved in import #128151

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Structured suggestion for extern crate foo when foo isn't resolved in import #128151

merged 1 commit into from
Jul 31, 2024

Conversation

estebank
Copy link
Contributor

When encountering a name in an import that could have come from a crate that wasn't imported, use a structured suggestion to suggest extern crate foo; pointing at the right place in the crate.

When encountering _ in an import, do not suggest extern crate _;.

error[E0432]: unresolved import `spam`
  --> $DIR/import-from-missing-star-3.rs:2:9
   |
LL |     use spam::*;
   |         ^^^^ maybe a missing crate `spam`?
   |
help: consider importing the `spam` crate
   |
LL + extern crate spam;
   |

@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the missing-extern-crate branch from bd9c135 to 9a7979d Compare July 24, 2024 21:05
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov self-assigned this Jul 24, 2024
@bors

This comment was marked as resolved.

Sign in to view
@estebank estebank force-pushed the missing-extern-crate branch from 9a7979d to 86fd79c Compare July 25, 2024 17:08
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2024
@estebank
Structured suggestion for extern crate foo when foo isn't resolve…
b61570a 
…d in import

When encountering a name in an import that could have come from a crate that wasn't imported, use a structured suggestion to suggest `extern crate foo;` pointing at the right place in the crate.

When encountering `_` in an import, do not suggest `extern crate _;`.

```
error[E0432]: unresolved import `spam`
  --> $DIR/import-from-missing-star-3.rs:2:9
   |
LL |     use spam::*;
   |         ^^^^ maybe a missing crate `spam`?
   |
help: consider importing the `spam` crate
   |
LL + extern crate spam;
   |
```
@estebank estebank force-pushed the missing-extern-crate branch from 86fd79c to b61570a Compare July 29, 2024 23:49
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 29, 2024
@petrochenkov
Copy link
Contributor

r? @petrochenkov
@bors r+

@bors
Copy link
Contributor

bors commented Jul 30, 2024

📌 Commit b61570a has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 30, 2024
@matthiaskrgr
Rollup merge of rust-lang#128151 - estebank:missing-extern-crate, r=p…
7b03344 
…etrochenkov

Structured suggestion for `extern crate foo` when `foo` isn't resolved in import

When encountering a name in an import that could have come from a crate that wasn't imported, use a structured suggestion to suggest `extern crate foo;` pointing at the right place in the crate.

When encountering `_` in an import, do not suggest `extern crate _;`.

```
error[E0432]: unresolved import `spam`
  --> $DIR/import-from-missing-star-3.rs:2:9
   |
LL |     use spam::*;
   |         ^^^^ maybe a missing crate `spam`?
   |
help: consider importing the `spam` crate
   |
LL + extern crate spam;
   |
```
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 30, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2024
@bors
Auto merge of rust-lang#128411 - matthiaskrgr:rollup-7oesxfs, r=matth…
2ce130d 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#127830 (When an archive fails to build, print the path)
 - rust-lang#128151 (Structured suggestion for `extern crate foo` when `foo` isn't resolved in import)
 - rust-lang#128161 (nested aux-build in tests/rustdoc/ tests)
 - rust-lang#128387 (More detailed note to deprecate ONCE_INIT)
 - rust-lang#128388 (Match LLVM ABI in `extern "C"` functions for `f128` on Windows)
 - rust-lang#128402 (Attribute checking simplifications)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#128151 - estebank:missing-extern-crate, r=p…
144a1bf 
…etrochenkov

Structured suggestion for `extern crate foo` when `foo` isn't resolved in import

When encountering a name in an import that could have come from a crate that wasn't imported, use a structured suggestion to suggest `extern crate foo;` pointing at the right place in the crate.

When encountering `_` in an import, do not suggest `extern crate _;`.

```
error[E0432]: unresolved import `spam`
  --> $DIR/import-from-missing-star-3.rs:2:9
   |
LL |     use spam::*;
   |         ^^^^ maybe a missing crate `spam`?
   |
help: consider importing the `spam` crate
   |
LL + extern crate spam;
   |
```
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 31, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 31, 2024
@bors
Auto merge of rust-lang#128423 - matthiaskrgr:rollup-61fbfeq, r=matth…
591d6b1 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#128151 (Structured suggestion for `extern crate foo` when `foo` isn't resolved in import)
 - rust-lang#128162 (Cleanup sys module to match house style)
 - rust-lang#128402 (Attribute checking simplifications)
 - rust-lang#128404 (Revert recent changes to dead code analysis)
 - rust-lang#128417 (Add `f16` and `f128` math functions)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#128151 - estebank:missing-extern-crate, r=p…
e90b7a3 
…etrochenkov

Structured suggestion for `extern crate foo` when `foo` isn't resolved in import

When encountering a name in an import that could have come from a crate that wasn't imported, use a structured suggestion to suggest `extern crate foo;` pointing at the right place in the crate.

When encountering `_` in an import, do not suggest `extern crate _;`.

```
error[E0432]: unresolved import `spam`
  --> $DIR/import-from-missing-star-3.rs:2:9
   |
LL |     use spam::*;
   |         ^^^^ maybe a missing crate `spam`?
   |
help: consider importing the `spam` crate
   |
LL + extern crate spam;
   |
```
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 31, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 31, 2024
@bors
Auto merge of rust-lang#128428 - matthiaskrgr:rollup-7weoxpo, r=matth…
827d104 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#128151 (Structured suggestion for `extern crate foo` when `foo` isn't resolved in import)
 - rust-lang#128162 (Cleanup sys module to match house style)
 - rust-lang#128402 (Attribute checking simplifications)
 - rust-lang#128417 (Add `f16` and `f128` math functions)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 31, 2024
@bors
Auto merge of rust-lang#128435 - matthiaskrgr:rollup-l76vu3i, r=matth…
99322d8 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#126454 (bump-stage0: use IndexMap for determinism)
 - rust-lang#127681 (derive(SmartPointer): rewrite bounds in where and generic bounds)
 - rust-lang#127830 (When an archive fails to build, print the path)
 - rust-lang#128151 (Structured suggestion for `extern crate foo` when `foo` isn't resolved in import)
 - rust-lang#128387 (More detailed note to deprecate ONCE_INIT)
 - rust-lang#128388 (Match LLVM ABI in `extern "C"` functions for `f128` on Windows)
 - rust-lang#128402 (Attribute checking simplifications)
 - rust-lang#128412 (Remove `crate_level_only` from `ELIDED_LIFETIMES_IN_PATHS`)
 - rust-lang#128430 (Use a separate pattern type for `rustc_pattern_analysis` diagnostics )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 336a378 into rust-lang:master Jul 31, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 31, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 31, 2024
@rust-timer
Unrolled build for rust-lang#128151
6e0aa5e 
Rollup merge of rust-lang#128151 - estebank:missing-extern-crate, r=petrochenkov

Structured suggestion for `extern crate foo` when `foo` isn't resolved in import

When encountering a name in an import that could have come from a crate that wasn't imported, use a structured suggestion to suggest `extern crate foo;` pointing at the right place in the crate.

When encountering `_` in an import, do not suggest `extern crate _;`.

```
error[E0432]: unresolved import `spam`
  --> $DIR/import-from-missing-star-3.rs:2:9
   |
LL |     use spam::*;
   |         ^^^^ maybe a missing crate `spam`?
   |
help: consider importing the `spam` crate
   |
LL + extern crate spam;
   |
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
6 participants
@estebank @rustbot @rust-log-analyzer @bors @petrochenkov @cjgillot