Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute rustc_codegen_cranelift for arm64 macOS #127177

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jun 30, 2024

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502

@bjorn3
Copy link
Member Author

bjorn3 commented Jun 30, 2024

@bors try

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2024
@rustbot

This comment was marked as outdated.

@bjorn3
Copy link
Member Author

bjorn3 commented Jun 30, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Based on rust-lang#127162

try-job: dist-aarch64-apple
@bors
Copy link
Contributor

bors commented Jun 30, 2024

⌛ Trying commit 342b280 with merge 02b5134...

@bors
Copy link
Contributor

bors commented Jun 30, 2024

☀️ Try build successful - checks-actions
Build commit: 02b5134 (02b5134048ef7779145b82c93c1402faba007fa7)

@bjorn3 bjorn3 force-pushed the arm64_macos_cg_clif branch from 342b280 to 9f7e049 Compare June 30, 2024 18:40
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2024
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 30, 2024

@bors try

@bjorn3 bjorn3 added A-cranelift Things relevant to the [future] cranelift backend and removed A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2024
@bors
Copy link
Contributor

bors commented Jun 30, 2024

⌛ Trying commit 9f7e049 with merge 25aede3...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Based on rust-lang#127162

try-job: dist-aarch64-apple
@bors
Copy link
Contributor

bors commented Jun 30, 2024

☀️ Try build successful - checks-actions
Build commit: 25aede3 (25aede3d73bda067767c0f1b5a43430d0fb7e4ad)

@bjorn3
Copy link
Member Author

bjorn3 commented Jul 1, 2024

I've confirmed it works. @rustbot ready

@wesleywiser
Copy link
Member

Bootstrap changes look fine to me but I don't know if @rust-lang/infra has any concerns about the effect on CI time.

r? infra-ci

@Kobzol
Copy link
Contributor

Kobzol commented Jul 17, 2024

The duration of the dist-aarch64-apple job was barely increased, I think that this is fine.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 20, 2024

📌 Commit 9f7e049 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 20, 2024
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 20, 2024
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jul 20, 2024
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2024
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#126450 (Promote Mac Catalyst targets to Tier 2, and ship with rustup)
 - rust-lang#127177 (Distribute rustc_codegen_cranelift for arm64 macOS)
 - rust-lang#127510 (Rewrite `test-float-parse` in Rust)
 - rust-lang#127720 ([`macro_metavar_expr_concat`] Allow `concat` in repetitions)
 - rust-lang#127734 (Windows: move BSD socket shims to netc)
 - rust-lang#127839 (Fix git safe-directory path for docker images)
 - rust-lang#128005 (Remove _tls_used hack)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 21, 2024
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126450 (Promote Mac Catalyst targets to Tier 2, and ship with rustup)
 - rust-lang#127177 (Distribute rustc_codegen_cranelift for arm64 macOS)
 - rust-lang#127510 (Rewrite `test-float-parse` in Rust)
 - rust-lang#127977 (Update wasi-sdk in CI to latest release)
 - rust-lang#127985 (Migrate `test-benches`, `c-unwind-abi-catch-panic` and `compiler-lookup-paths-2` `run-make` tests to rmake)
 - rust-lang#128023 (rustdoc: short descriptions cause word-breaks in tables)

r? `@ghost`
`@rustbot` modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request Jul 21, 2024
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 21, 2024
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2024
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#126450 (Promote Mac Catalyst targets to Tier 2, and ship with rustup)
 - rust-lang#127177 (Distribute rustc_codegen_cranelift for arm64 macOS)
 - rust-lang#127583 (Deal with invalid UTF-8 from `gai_strerror`)
 - rust-lang#127977 (Update wasi-sdk in CI to latest release)
 - rust-lang#127985 (Migrate `test-benches`, `c-unwind-abi-catch-panic` and `compiler-lookup-paths-2` `run-make` tests to rmake)
 - rust-lang#128014 (Fix stab display in doc blocks)
 - rust-lang#128023 (rustdoc: short descriptions cause word-breaks in tables)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2024
Rollup of 8 pull requests

Successful merges:

 - rust-lang#127177 (Distribute rustc_codegen_cranelift for arm64 macOS)
 - rust-lang#127415 (Add missing try_new_uninit_slice_in and try_new_zeroed_slice_in)
 - rust-lang#127510 (Rewrite `test-float-parse` in Rust)
 - rust-lang#127977 (Update wasi-sdk in CI to latest release)
 - rust-lang#127985 (Migrate `test-benches`, `c-unwind-abi-catch-panic` and `compiler-lookup-paths-2` `run-make` tests to rmake)
 - rust-lang#127996 (Clean up warnings + `unsafe_op_in_unsafe_fn` when building std for armv6k-nintendo-3ds)
 - rust-lang#128035 (Add test for rust-lang#125837)
 - rust-lang#128054 (mw triagebot vacation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b66b402 into rust-lang:master Jul 22, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2024
Rollup merge of rust-lang#127177 - bjorn3:arm64_macos_cg_clif, r=Mark-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
@bjorn3 bjorn3 deleted the arm64_macos_cg_clif branch July 22, 2024 11:45
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Aug 9, 2024
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cranelift Things relevant to the [future] cranelift backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustc-codegen-cranelift-preview support for aarch64-apple-darwin
6 participants