-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: update to pulldown-cmark 0.11 #127127
rustdoc: update to pulldown-cmark 0.11 #127127
Conversation
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
1057b45
to
24b6797
Compare
YES, FINALLY! Thanks so much for this update! r=me once CI pass |
This comment has been minimized.
This comment has been minimized.
24b6797
to
afb9737
Compare
This comment has been minimized.
This comment has been minimized.
afb9737
to
a5fc783
Compare
@bors r=GuillaumeGomez |
…-0.11, r=GuillaumeGomez rustdoc: update to pulldown-cmark 0.11 r? rustdoc This pull request updates rustdoc to the latest version of pulldown-cmark. Along with adding new markdown extensions (which this PR doesn't enable), the new pulldown-cmark version also fixes a large number of bugs. Because all text files successfully parse as markdown, these bugfixes change the output, which can break people's existing docs. A crater run, rust-lang#121659, has already been run for this change. The first commit upgrades and fixes rustdoc. The second commit adds a lint for the footnote and block quote parser changes, which break the largest numbers of docs in the Crater run. The strikethrough change was mitigated in pulldown-cmark itself. Unblocks rust-lang/rust-clippy#12876
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123778 (Improve autovectorization of to_lowercase / to_uppercase functions) - rust-lang#126705 (Updated docs on `#[panic_handler]` in `library/core/src/lib.rs`) - rust-lang#126876 (Add `.ignore` file to make `config.toml` searchable in vscode) - rust-lang#126906 (Small fixme in core now that split_first has no codegen issues) - rust-lang#127127 (rustdoc: update to pulldown-cmark 0.11) - rust-lang#127131 (Remove unused `rustc_trait_selection` dependencies) - rust-lang#127134 (Print `TypeId` as a `u128` for `Debug`) r? `@ghost` `@rustbot` modify labels: rollup
…-0.11, r=GuillaumeGomez rustdoc: update to pulldown-cmark 0.11 r? rustdoc This pull request updates rustdoc to the latest version of pulldown-cmark. Along with adding new markdown extensions (which this PR doesn't enable), the new pulldown-cmark version also fixes a large number of bugs. Because all text files successfully parse as markdown, these bugfixes change the output, which can break people's existing docs. A crater run, rust-lang#121659, has already been run for this change. The first commit upgrades and fixes rustdoc. The second commit adds a lint for the footnote and block quote parser changes, which break the largest numbers of docs in the Crater run. The strikethrough change was mitigated in pulldown-cmark itself. Unblocks rust-lang/rust-clippy#12876
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#126705 (Updated docs on `#[panic_handler]` in `library/core/src/lib.rs`) - rust-lang#126876 (Add `.ignore` file to make `config.toml` searchable in vscode) - rust-lang#126906 (Small fixme in core now that split_first has no codegen issues) - rust-lang#127127 (rustdoc: update to pulldown-cmark 0.11) - rust-lang#127131 (Remove unused `rustc_trait_selection` dependencies) - rust-lang#127134 (Print `TypeId` as a `u128` for `Debug`) r? `@ghost` `@rustbot` modify labels: rollup
@bors r- rollup=iffy |
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in coverage instrumentation. cc @Zalathar |
This didn't produce working footnote links. The unportable markdown lint warned about it.
cc57a5b
to
c8592da
Compare
Fix bare URL warnings... @bors r=GuillaumeGomez |
….11, r=GuillaumeGomez rustdoc: update to pulldown-cmark 0.11 r? rustdoc This pull request updates rustdoc to the latest version of pulldown-cmark. Along with adding new markdown extensions (which this PR doesn't enable), the new pulldown-cmark version also fixes a large number of bugs. Because all text files successfully parse as markdown, these bugfixes change the output, which can break people's existing docs. A crater run, rust-lang#121659, has already been run for this change. The first commit upgrades and fixes rustdoc. The second commit adds a lint for the footnote and block quote parser changes, which break the largest numbers of docs in the Crater run. The strikethrough change was mitigated in pulldown-cmark itself. Unblocks rust-lang/rust-clippy#12876
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
No way this caused that. @bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (66b4f00): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 2.1%, secondary 0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.6%, secondary -0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 742.044s -> 720.847s (-2.86%) |
This was an update to a newer version of a third-party dependency, so nothing much that we can do here. The update also apparently resolves several bugs, and we do more work per doc block. Marking as triaged. @rustbot label: +perf-regression-triaged |
….11, r=GuillaumeGomez rustdoc: update to pulldown-cmark 0.11 r? rustdoc This pull request updates rustdoc to the latest version of pulldown-cmark. Along with adding new markdown extensions (which this PR doesn't enable), the new pulldown-cmark version also fixes a large number of bugs. Because all text files successfully parse as markdown, these bugfixes change the output, which can break people's existing docs. A crater run, rust-lang#121659, has already been run for this change. The first commit upgrades and fixes rustdoc. The second commit adds a lint for the footnote and block quote parser changes, which break the largest numbers of docs in the Crater run. The strikethrough change was mitigated in pulldown-cmark itself. Unblocks rust-lang/rust-clippy#12876
r? rustdoc
This pull request updates rustdoc to the latest version of pulldown-cmark. Along with adding new markdown extensions (which this PR doesn't enable), the new pulldown-cmark version also fixes a large number of bugs. Because all text files successfully parse as markdown, these bugfixes change the output, which can break people's existing docs.
A crater run, #121659, has already been run for this change.
The first commit upgrades and fixes rustdoc. The second commit adds a lint for the footnote and block quote parser changes, which break the largest numbers of docs in the Crater run. The strikethrough change was mitigated in pulldown-cmark itself.
Unblocks rust-lang/rust-clippy#12876