Implement simple, unstable lint to suggest turning closure-of-async-block into async-closure #127097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
async-closure-lint
branch
from
284d3cf to
987fd17
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
async-closure-lint
branch
from
987fd17 to
acc13e2
Compare
|
r? @oli-obk |
oli-obk
approved these changes
Jul 10, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 11, 2024
…, r=oli-obk
Implement simple, unstable lint to suggest turning closure-of-async-block into async-closure
We want to eventually suggest people to turn `|| async {}` to `async || {}`. This begins doing that. It's a pretty rudimentary lint, but I wanted to get something down so I wouldn't lose the code.
Tracking:
* rust-lang#62290
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 11, 2024
Rollup of 3 pull requests Successful merges: - rust-lang#127097 (Implement simple, unstable lint to suggest turning closure-of-async-block into async-closure) - rust-lang#127153 (Initial implementation of anonymous_pipe API) - rust-lang#127572 (Don't mark `DEBUG_EVENT` struct as `repr(packed)`) r? `@ghost` `@rustbot` modify labels: rollup
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (9b00430): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 3.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 703.504s -> 703.344s (-0.02%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to eventually suggest people to turn
|| async {}toasync || {}. This begins doing that. It's a pretty rudimentary lint, but I wanted to get something down so I wouldn't lose the code.Tracking:
# #62290