Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update browser-ui-test version to 0.18.0 #127010

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Update browser-ui-test version to 0.18.0 #127010

merged 1 commit into from
Jun 28, 2024

Conversation

GuillaumeGomez
Copy link
Member

Should help with #126436.

r? @notriddle

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 26, 2024
@notriddle
Copy link
Contributor

notriddle commented Jun 27, 2024 •
edited
Loading

Does this fix help-page.goml?

@GuillaumeGomez
Copy link
Member Author

Hopefully yes. help.goml always worked locally so only way to know is by making a new PR adding it back. For now, it's mostly to ensure that we use the latest puppeteer version. Then I'll make a PR adding back help.goml and we'll see if it works again.

@notriddle
Copy link
Contributor

Sure, that makes sense.

@bors r+

@bors
Copy link
Contributor

bors commented Jun 27, 2024

📌 Commit 315be7d has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 27, 2024
@GuillaumeGomez
Rollup merge of rust-lang#127010 - GuillaumeGomez:update-puppeteer, r…
0df1058 
…=notriddle

Update browser-ui-test version to `0.18.0`

Should help with rust-lang#126436.

r? `@notriddle`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 27, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 27, 2024
@bors
Auto merge of rust-lang#127046 - GuillaumeGomez:rollup-zny4j7m, r=Gui…
2cb0ec8 
…llaumeGomez

Rollup of 10 pull requests

Successful merges:

 - rust-lang#123237 (Various rustc_codegen_ssa cleanups)
 - rust-lang#123714 (Add test for fn pointer duplication.)
 - rust-lang#124091 (Update AST validation module docs)
 - rust-lang#126835 (Simplifications in match lowering)
 - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR)
 - rust-lang#127010 (Update browser-ui-test version to `0.18.0`)
 - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default)
 - rust-lang#127016 (docs: check if the disambiguator matches its suffix)
 - rust-lang#127029 (Fix Markdown tables in platform-support.md)
 - rust-lang#127032 (Enable const casting for `f16` and `f128`)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#127010 - GuillaumeGomez:update-puppeteer, r…
8a4c44a 
…=notriddle

Update browser-ui-test version to `0.18.0`

Should help with rust-lang#126436.

r? ``@notriddle``
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 27, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 27, 2024
@bors
Auto merge of rust-lang#127056 - matthiaskrgr:rollup-9cyvjqp, r=matth…
4b2a005 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#123237 (Various rustc_codegen_ssa cleanups)
 - rust-lang#123714 (Add test for fn pointer duplication.)
 - rust-lang#124091 (Update AST validation module docs)
 - rust-lang#126835 (Simplifications in match lowering)
 - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR)
 - rust-lang#127010 (Update browser-ui-test version to `0.18.0`)
 - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default)
 - rust-lang#127029 (Fix Markdown tables in platform-support.md)
 - rust-lang#127032 (Enable const casting for `f16` and `f128`)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 28, 2024
@jhpratt
Rollup merge of rust-lang#127010 - GuillaumeGomez:update-puppeteer, r…
d19478b 
…=notriddle

Update browser-ui-test version to `0.18.0`

Should help with rust-lang#126436.

r? ```@notriddle```
@jhpratt jhpratt mentioned this pull request Jun 28, 2024
Closed
@matthiaskrgr
Copy link
Member

@bors rollup=never
since it miight be causing weird problems, just speculating

@bors
Copy link
Contributor

bors commented Jun 28, 2024

⌛ Testing commit 315be7d with merge 42add88...

@bors
Copy link
Contributor

bors commented Jun 28, 2024

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 42add88 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 28, 2024
@bors bors merged commit 42add88 into rust-lang:master Jun 28, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (42add88): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 7.2% [7.2%, 7.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.5%, secondary 5.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.5% [5.5%, 5.5%] 1
Improvements ✅
(primary)		 -2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.5% [-2.5%, -2.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 697.882s -> 697.835s (-0.01%)
Artifact size: 326.66 MiB -> 326.76 MiB (0.03%)

@rustbot rustbot added the perf-regression Performance regression. label Jun 28, 2024
@lqd
Copy link
Member

lqd commented Jun 28, 2024 •
edited
Loading

deep-vector is currently being incredibly noisy, @rustbot label: +perf-regression-triaged

image

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 28, 2024
@GuillaumeGomez GuillaumeGomez deleted the update-puppeteer branch June 28, 2024 09:24
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 28, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2024
@bors
Auto merge of rust-lang#127082 - GuillaumeGomez:help-gui-test, r=notr…
ad12a2a 
…iddle

Add back `help-page.goml` rustdoc GUI test

Since rust-lang#127010 was merged, let's see if we can revert rust-lang#126445...

r? `@notriddle`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Jul 2, 2024
@bors
Auto merge of #127082 - GuillaumeGomez:help-gui-test, r=notriddle
62cbc83 
Add back `help-page.goml` rustdoc GUI test

Since rust-lang/rust#127010 was merged, let's see if we can revert rust-lang/rust#126445...

r? `@notriddle`
@pnkfelix pnkfelix mentioned this pull request Jul 2, 2024
Merged
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jul 11, 2024
@bors
Auto merge of #127082 - GuillaumeGomez:help-gui-test, r=notriddle
c458863 
Add back `help-page.goml` rustdoc GUI test

Since rust-lang/rust#127010 was merged, let's see if we can revert rust-lang/rust#126445...

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @notriddle @bors @matthiaskrgr @rust-timer @lqd @rustbot