Migrate run-make/allow-non-lint-warnings-cmdline to rmake.rs
#126386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
The run-make-support library was changed cc @jieyouxu This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
migrate-run-make-allow-non-lint-warnings-cmdline
branch
from
2134604 to
115fa2e
Compare
|
And fixed the formatting issue. |
jieyouxu
reviewed
Jun 13, 2024
| @@ -0,0 +1,8 @@ | |||
| // Test that -A warnings makes the 'empty trait list for derive' warning go away. | |||
There was a problem hiding this comment.
Discussion: I thought about this a bit, could this be written as a UI test? Something like
//@ compile-flags: -Awarnings
//@ check-pass
#[derive()]
#[derive(Copy, Clone)]
pub struct Foo;
pub fn main() {}and then obviously the stderr would be blessed which would not have any warnings?
I'm trying this locally, let me get back to you.
There was a problem hiding this comment.
Yes it could actually. Do you prefer me to switch this test to a ui test?
There was a problem hiding this comment.
Yeah, if it doesn't really need the facilities or flexibilities of run-make tests, it's usually better as ui tests. EDIT: yes looks like it does work as a UI test with the snippet above, doesn't even have a stderr to track 😄
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
migrate-run-make-allow-non-lint-warnings-cmdline
branch
3 times, most recently
from
1336292 to
eca8d20
Compare
|
Turned it into a ui test. :) |
jieyouxu
approved these changes
Jun 13, 2024
|
@bors r=jieyouxu |
bors
added
S-waiting-on-bors
|
@bors rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 13, 2024
…low-non-lint-warnings-cmdline, r=jieyouxu Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 14, 2024
…low-non-lint-warnings-cmdline, r=jieyouxu Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs` Part of rust-lang#121876. r? ``@jieyouxu``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates) - rust-lang#124884 (place explicit lifetime bound after generic param) - rust-lang#126244 (Update fuchsia commit, and SDK to 21.20240610.2.1) - rust-lang#126270 (Migrate run make const fn mir) - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns) - rust-lang#126343 (Remove some msys2 utils) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126368 (Remove some unnecessary crate dependencies.) - rust-lang#126386 (Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs`) - rust-lang#126449 (Fill out missing Windows support information) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124884 (place explicit lifetime bound after generic param) - rust-lang#126343 (Remove some msys2 utils) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126368 (Remove some unnecessary crate dependencies.) - rust-lang#126386 (Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
Rollup merge of rust-lang#126386 - GuillaumeGomez:migrate-run-make-allow-non-lint-warnings-cmdline, r=jieyouxu Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs` Part of rust-lang#121876. r? ```@jieyouxu```
GuillaumeGomez
deleted the
migrate-run-make-allow-non-lint-warnings-cmdline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876.
r? @jieyouxu