Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_lint cleanups #125057

Merged
merged 3 commits into from
Jun 3, 2024
Merged

rustc_lint cleanups #125057

merged 3 commits into from
Jun 3, 2024

Conversation

nnethercote
Copy link
Contributor

Minor improvements I found while looking through this code.

r? @cjgillot

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 13, 2024
@cjgillot cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2024
@nnethercote nnethercote force-pushed the rustc_lint-cleanups branch from 4e48cf6 to bddbaa6 Compare May 20, 2024 05:41
@bors
Copy link
Contributor

bors commented May 21, 2024

☔ The latest upstream changes (presumably #124097) made this pull request unmergeable. Please resolve the merge conflicts.

@nnethercote nnethercote force-pushed the rustc_lint-cleanups branch from bddbaa6 to deda6d9 Compare May 21, 2024 22:15
@nnethercote
Copy link
Contributor Author

I rebased.

@bors
Copy link
Contributor

bors commented May 24, 2024

☔ The latest upstream changes (presumably #125434) made this pull request unmergeable. Please resolve the merge conflicts.

@nnethercote
Copy link
Contributor Author

I rebased and added the check_gated_lint to the other case. The first commit also disappeared because I ended up doing that extern crate tracing; removal in #125434. Should be ready to merge.

@nnethercote nnethercote force-pushed the rustc_lint-cleanups branch from deda6d9 to f279d3e Compare May 27, 2024 04:02
@cjgillot
Copy link
Contributor

cjgillot commented Jun 1, 2024

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Jun 1, 2024

📌 Commit f279d3e has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 1, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#125057 - nnethercote:rustc_lint-cleanups, r…
1b9e8fa 
…=cjgillot

`rustc_lint` cleanups

Minor improvements I found while looking through this code.

r? `@cjgillot`
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 1, 2024
Closed
@matthiaskrgr
Copy link
Member

@bors r-
just needs reformatting I guess
#125857 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 1, 2024
@nnethercote
Fix up comments.
22ca74f 
Wrap overly long ones, etc.
@nnethercote
Reduce some pub exposure.
d070e89
@nnethercote
Tweak CheckLintNameResult::Tool.
32c8a12 
It has a clumsy type, with repeated `&'a [LintId]`, and sometimes
requires an empty string that isn't used in the `Err`+`None` case.

This commit splits it into two variants.
@nnethercote nnethercote force-pushed the rustc_lint-cleanups branch from f279d3e to 32c8a12 Compare June 2, 2024 23:33
@nnethercote
Copy link
Contributor Author

nnethercote commented Jun 2, 2024 •
edited
Loading

I fixed the formatting.

@bors r=cjgillot

@bors
Copy link
Contributor

bors commented Jun 2, 2024

📌 Commit 32c8a12 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2024
@nnethercote
Copy link
Contributor Author

@bors rollup

@bors
Copy link
Contributor

bors commented Jun 3, 2024

⌛ Testing commit 32c8a12 with merge 9f2d0b3...

@bors
Copy link
Contributor

bors commented Jun 3, 2024

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 9f2d0b3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 3, 2024
@bors bors merged commit 9f2d0b3 into rust-lang:master Jun 3, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Jun 3, 2024
@nnethercote nnethercote deleted the rustc_lint-cleanups branch June 3, 2024 03:16
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9f2d0b3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

Cycles

Results (secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.4% [2.3%, 2.4%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.336s -> 667.872s (0.08%)
Artifact size: 318.97 MiB -> 318.92 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nnethercote @bors @cjgillot @matthiaskrgr @rust-timer @rustbot