-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
from_str_radix: outline only the panic function #124863
Conversation
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (cf77474): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.435s -> 676.035s (0.24%) |
In the
{integer}::from_str_radix
function, the radix check is labeled ascold
andinline(never)
, along with its corresponding panic. It probably was intended to apply these attributes only to the panic function.