-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable two debuginfo tests failing under the future GDB 15 release #123963
Conversation
it seems gdb 15 regresses some of our debuginfo tests. disable them temporarily so that CI doesn't randomly start failing soon.
The GDB 15 failure is starting to break our CI: #123468 (comment). |
I'm going to go ahead and approve this to unblock CI, as it is a hotfix. @bors r+ p=10 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ad18fe0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 678.471s -> 678.547s (0.01%) |
[beta] backports - Silence `unused_imports` lint for redundant imports rust-lang#123744 - Call the panic hook for non-unwind panics in proc-macros rust-lang#123825 - rustdoc: check redundant explicit links with correct itemid rust-lang#123905 - disable two debuginfo tests under gdb 15 rust-lang#123963 r? cuviper
From the linked issues it looks like the python pretty printers need to be updated, but I haven't had time yet to investigate in more detail. |
As seen in #123960, it seems two of our debuginfo tests started failing on gdb 15, which is also already in use in the
x86_64-gnu-llvm-18
builder: CI will randomly start to fail whenever this cached docker image expires.This PR disables the following two tests under gdb 15+, to prevent future CI failures.
tests/debuginfo/include_string.rs
tests/debuginfo/vec-slices.rs
This seems very much related to https://sourceware.org/bugzilla/show_bug.cgi?id=30330 and https://sourceware.org/bugzilla/show_bug.cgi?id=31517 -- and I just now saw #122751 as well, where one of these bugzilla issues and one of the two test failures here was previously mentioned.
I don't know whether these are unexpected gdb changes, or if we need to change our tests as it seems some of the gdb changes are definitely intentional, so I'll just cc @rust-lang/wg-debugging and @tromey.
(In the same area,
tests/debuginfo/unsized.rs
was previously disabled due to https://sourceware.org/bugzilla/show_bug.cgi?id=30330. This issue has been fixed but I don't believe our test passes, so it's in the same boat as the 2 above regarding whether this test is expected to work or needs changes as well)r? wg-debugging
I've confirmed this is enough to have CI pass on gdb 15 with the llvm 18 builder.