Support ?Trait bounds in supertraits and dyn Trait under a feature gate #121676

Bryanskiy · 2024-02-27T14:11:45Z

This patch allows maybe polarity bounds under a feature gate. The only language change here is that corresponding hard errors are replaced by feature gates. Example:

#![feature(allow_maybe_polarity)]
...
trait Trait1 : ?Trait { ... } // ok
fn foo(_: Box<(dyn Trait2 + ?Trait)>) {} // ok
fn bar<T: ?Sized + ?Trait>(_: &T) {} // ok

Maybe bounds still don't do anything (except for Sized trait), however this patch will allow us to experiment with default auto traits.

This is a part of the MCP: Low level components for async drop

rustbot · 2024-02-27T14:11:53Z

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Noratrieb · 2024-02-27T14:37:10Z

for reference, is there any language team shepherd for all of this default bound experimentation? I only ever see random work and don't remember seeing design documents or anything like that

petrochenkov · 2024-02-27T14:46:43Z

@Nilstrieb
I'll make a compiler team MCP for core components for async drop enabling library experimentation soon.
@traviscross is currently the Async WG liaison for this stuff (I actually assumed he was on lang team as well, but apparently not).

Bryanskiy · 2024-02-27T15:27:19Z

@rustbot author

rustbot · 2024-02-27T15:55:16Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Bryanskiy · 2024-02-27T16:48:19Z

@rustbot ready

rustbot · 2024-02-29T14:26:24Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

compiler/rustc_error_codes/src/error_codes/E0203.md

compiler/rustc_feature/src/unstable.rs

tests/ui/feature-gates/feature-gate-allow-maybe-polarity.rs

compiler/rustc_hir/src/intravisit.rs

compiler/rustc_ast_passes/src/feature_gate.rs

compiler/rustc_hir_analysis/src/astconv/bounds.rs

compiler/rustc_hir_analysis/src/collect/resolve_bound_vars.rs

petrochenkov · 2024-03-01T14:06:48Z

Need to link to rust-lang/compiler-team#727 from this PR description.
@rustbot author

Support ?Trait bounds in supertraits and dyn Trait under a feature gate This patch allows `maybe` polarity bounds under a feature gate. The only language change here is that corresponding hard errors are replaced by feature gates. Example: ```rust #![feature(allow_maybe_polarity)] ... trait Trait1 : ?Trait { ... } // ok fn foo(_: Box<(dyn Trait2 + ?Trait)>) {} // ok fn bar<T: ?Sized + ?Trait>(_: &T) {} // ok ``` Maybe bounds still don't do anything (except for `Sized` trait), however this patch will allow us to [experiment with default auto traits](rust-lang#120706 (comment)). This is a part of the [MCP: Low level components for async drop](rust-lang/compiler-team#727)

matthiaskrgr · 2024-07-25T16:57:02Z

@bors r-
tests need rebase/blessing I guess #128191 (comment)

Bryanskiy · 2024-07-26T13:44:41Z

The latest commit fixes this

@rustbot ready

petrochenkov · 2024-07-26T14:03:10Z

@bors r+

bors · 2024-07-26T14:03:12Z

📌 Commit fd9d0bf has been approved by petrochenkov

It is now in the queue for this repository.

Support ?Trait bounds in supertraits and dyn Trait under a feature gate This patch allows `maybe` polarity bounds under a feature gate. The only language change here is that corresponding hard errors are replaced by feature gates. Example: ```rust #![feature(allow_maybe_polarity)] ... trait Trait1 : ?Trait { ... } // ok fn foo(_: Box<(dyn Trait2 + ?Trait)>) {} // ok fn bar<T: ?Sized + ?Trait>(_: &T) {} // ok ``` Maybe bounds still don't do anything (except for `Sized` trait), however this patch will allow us to [experiment with default auto traits](rust-lang#120706 (comment)). This is a part of the [MCP: Low level components for async drop](rust-lang/compiler-team#727)

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#121676 (Support ?Trait bounds in supertraits and dyn Trait under a feature gate) - rust-lang#124339 (allow overwriting the output of `rustc --version`) - rust-lang#128223 (Refactor complex conditions in `collect_tokens_trailing_token`) - rust-lang#128224 (Remove unnecessary range replacements) - rust-lang#128226 (Remove redundant option that was just encoding that a slice was empty) - rust-lang#128227 (CI: do not respect custom try jobs for unrolled perf builds) r? `@ghost` `@rustbot` modify labels: rollup

Support ?Trait bounds in supertraits and dyn Trait under a feature gate This patch allows `maybe` polarity bounds under a feature gate. The only language change here is that corresponding hard errors are replaced by feature gates. Example: ```rust #![feature(allow_maybe_polarity)] ... trait Trait1 : ?Trait { ... } // ok fn foo(_: Box<(dyn Trait2 + ?Trait)>) {} // ok fn bar<T: ?Sized + ?Trait>(_: &T) {} // ok ``` Maybe bounds still don't do anything (except for `Sized` trait), however this patch will allow us to [experiment with default auto traits](rust-lang#120706 (comment)). This is a part of the [MCP: Low level components for async drop](rust-lang/compiler-team#727)

Rollup of 9 pull requests Successful merges: - rust-lang#121676 (Support ?Trait bounds in supertraits and dyn Trait under a feature gate) - rust-lang#124941 (Stabilize const `{integer}::from_str_radix` i.e. `const_int_from_str`) - rust-lang#128210 (rustdoc: change title of search results) - rust-lang#128223 (Refactor complex conditions in `collect_tokens_trailing_token`) - rust-lang#128224 (Remove unnecessary range replacements) - rust-lang#128226 (Remove redundant option that was just encoding that a slice was empty) - rust-lang#128227 (CI: do not respect custom try jobs for unrolled perf builds) - rust-lang#128229 (Improve `extern "<abi>" unsafe fn()` error message) - rust-lang#128235 (Fix `Iterator::filter` docs) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-07-26T20:14:19Z

⌛ Testing commit fd9d0bf with merge 7c2012d...

bors · 2024-07-26T22:37:34Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 7c2012d to master...

rust-timer · 2024-07-26T23:55:18Z

Finished benchmarking commit (7c2012d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.319s -> 770.229s (0.12%)
Artifact size: 328.91 MiB -> 328.95 MiB (0.01%)

Support ?Trait bounds in supertraits and dyn Trait under a feature gate This patch allows `maybe` polarity bounds under a feature gate. The only language change here is that corresponding hard errors are replaced by feature gates. Example: ```rust #![feature(allow_maybe_polarity)] ... trait Trait1 : ?Trait { ... } // ok fn foo(_: Box<(dyn Trait2 + ?Trait)>) {} // ok fn bar<T: ?Sized + ?Trait>(_: &T) {} // ok ``` Maybe bounds still don't do anything (except for `Sized` trait), however this patch will allow us to [experiment with default auto traits](rust-lang#120706 (comment)). This is a part of the [MCP: Low level components for async drop](rust-lang/compiler-team#727)

rustbot assigned petrochenkov Feb 27, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 27, 2024

Bryanskiy force-pushed the polarity branch from 438e259 to 8226783 Compare February 27, 2024 14:36

This comment has been minimized.

Sign in to view

Bryanskiy changed the title ~~allow_maybe_polarity feature~~ Support ?Trait bounds in supertraits and dyn Trait under a feature gate Feb 27, 2024

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2024

Bryanskiy force-pushed the polarity branch from 8226783 to 88d62c9 Compare February 27, 2024 15:55

Bryanskiy force-pushed the polarity branch from 88d62c9 to 743d2e5 Compare February 27, 2024 15:57

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2024

petrochenkov mentioned this pull request Feb 28, 2024

MCP: Low level components for async drop rust-lang/compiler-team#727

Closed

3 tasks

Bryanskiy force-pushed the polarity branch from 743d2e5 to 8a57aea Compare February 29, 2024 14:26

Bryanskiy force-pushed the polarity branch from 8a57aea to b7435de Compare February 29, 2024 14:39

GuillaumeGomez reviewed Feb 29, 2024

View reviewed changes

compiler/rustc_error_codes/src/error_codes/E0203.md Outdated Show resolved Hide resolved

petrochenkov reviewed Mar 1, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2024

Bryanskiy force-pushed the polarity branch 2 times, most recently from d84587a to 540fde9 Compare March 1, 2024 17:06

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 25, 2024

matthiaskrgr mentioned this pull request Jul 25, 2024

Rollup of 7 pull requests #128191

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 25, 2024

Bryanskiy added 2 commits July 25, 2024 20:53

Support ?Trait bounds in supertraits and dyn Trait under a feature gate

2a73553

Forbid ?Trait bounds repetitions

fd9d0bf

Bryanskiy force-pushed the polarity branch from f6d1bc6 to fd9d0bf Compare July 26, 2024 13:35

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 26, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2024

matthiaskrgr mentioned this pull request Jul 26, 2024

Rollup of 6 pull requests #128230

Closed

tgross35 mentioned this pull request Jul 26, 2024

Rollup of 9 pull requests #128237

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 26, 2024

bors merged commit 7c2012d into rust-lang:master Jul 26, 2024
7 checks passed

rustbot added this to the 1.82.0 milestone Jul 26, 2024

bors mentioned this pull request Jul 26, 2024

Rework non_local_definitions lint to only use a syntactic heuristic #127117

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support ?Trait bounds in supertraits and dyn Trait under a feature gate #121676

Support ?Trait bounds in supertraits and dyn Trait under a feature gate #121676

Bryanskiy commented Feb 27, 2024 •

edited

Loading

rustbot commented Feb 27, 2024

Noratrieb commented Feb 27, 2024

This comment has been minimized.

petrochenkov commented Feb 27, 2024

Bryanskiy commented Feb 27, 2024

rustbot commented Feb 27, 2024

Bryanskiy commented Feb 27, 2024

rustbot commented Feb 29, 2024

petrochenkov commented Mar 1, 2024

matthiaskrgr commented Jul 25, 2024

Bryanskiy commented Jul 26, 2024

petrochenkov commented Jul 26, 2024

bors commented Jul 26, 2024

bors commented Jul 26, 2024

bors commented Jul 26, 2024

rust-timer commented Jul 26, 2024

Support ?Trait bounds in supertraits and dyn Trait under a feature gate #121676

Support ?Trait bounds in supertraits and dyn Trait under a feature gate #121676

Conversation

Bryanskiy commented Feb 27, 2024 • edited Loading

rustbot commented Feb 27, 2024

Noratrieb commented Feb 27, 2024

This comment has been minimized.

petrochenkov commented Feb 27, 2024

Bryanskiy commented Feb 27, 2024

rustbot commented Feb 27, 2024

Bryanskiy commented Feb 27, 2024

rustbot commented Feb 29, 2024

petrochenkov commented Mar 1, 2024

matthiaskrgr commented Jul 25, 2024

Bryanskiy commented Jul 26, 2024

petrochenkov commented Jul 26, 2024

bors commented Jul 26, 2024

bors commented Jul 26, 2024

bors commented Jul 26, 2024

rust-timer commented Jul 26, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Bryanskiy commented Feb 27, 2024 •

edited

Loading