-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unstable -Zdefault-hidden-visibility
cmdline flag for rustc
.
#118417
Conversation
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in compiler/rustc_codegen_gcc cc @antoyo These commits modify compiler targets. |
This comment has been minimized.
This comment has been minimized.
@rustbot label +S-waiting-on-author -S-waiting-on-review I need to fix the test failures reported above. AFAICT they didn't show up when I've run |
8f2763e
to
1a0829c
Compare
Thanks @anforowicz ! Not sure when I was ever going to finally get around to this if you didn't pick it up. |
@rustbot label -S-waiting-on-author +S-waiting-on-review |
@TaKO8Ki do you have some time to look at this? It's going to solve some important issues for us (Brave/Chromium) |
@bridiver Sorry. I missed it. I'll take a look. |
Sorry for the late review! @bors r+ rollup |
…ty, r=TaKO8Ki Add unstable `-Zdefault-hidden-visibility` cmdline flag for `rustc`. The new flag has been described in the Major Change Proposal at rust-lang/compiler-team#656
…ty, r=TaKO8Ki Add unstable `-Zdefault-hidden-visibility` cmdline flag for `rustc`. The new flag has been described in the Major Change Proposal at rust-lang/compiler-team#656
…ty, r=TaKO8Ki Add unstable `-Zdefault-hidden-visibility` cmdline flag for `rustc`. The new flag has been described in the Major Change Proposal at rust-lang/compiler-team#656
…ty, r=TaKO8Ki Add unstable `-Zdefault-hidden-visibility` cmdline flag for `rustc`. The new flag has been described in the Major Change Proposal at rust-lang/compiler-team#656
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#118150 (Add new targets {x86_64,i686}-win7-windows-msvc) - rust-lang#118417 (Add unstable `-Zdefault-hidden-visibility` cmdline flag for `rustc`.) - rust-lang#118692 (remove redundant imports) - rust-lang#118694 (Add instance evaluation and methods to read an allocation in StableMIR) - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.) r? `@ghost` `@rustbot` modify labels: rollup
This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
2aa739f
to
2afa054
Compare
This comment has been minimized.
This comment has been minimized.
2afa054
to
10db282
Compare
This comment has been minimized.
This comment has been minimized.
10db282
to
f81e384
Compare
That was accidental and should be fixed now. |
@TaKO8Ki, could you PTAL again? The only change is in @rustbot label -S-waiting-on-author +S-waiting-on-review Let me also discuss some alternative testing approaches that I have considered for this PR. If there is a desire to cover additional target triples (now or (preferably) in a separate follow-up PR), then:
Instead of per-triple test expectations, we could also tweak and relax the patterns being matched against (e.g. saying |
Actually, I think it would be safest if I specified the full triple, because |
The new flag has been described in the Major Change Proposal at rust-lang/compiler-team#656
f81e384
to
981c4e3
Compare
Ok - switched to |
Sure. @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (9d49eb7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.867s -> 670.776s (-0.01%) |
The new flag has been described in the Major Change Proposal at
rust-lang/compiler-team#656