Suggest trait bounds for used associated type on type param #116257

estebank · 2023-09-29T03:16:56Z

When an associated type on a type parameter is used, and the type parameter isn't constrained by the correct trait, suggest the appropriate trait bound:

error[E0220]: associated type `Associated` not found for `T`
 --> file.rs:6:15
  |
6 |     field: T::Associated,
  |               ^^^^^^^^^^ there is a similarly named associated type `Associated` in the trait `Foo`
  |
help: consider restricting type parameter `T`
  |
5 | struct Generic<T: Foo> {
  |                 +++++

When an associated type on a type parameter has a typo, suggest fixing
it:

error[E0220]: associated type `Baa` not found for `T`
  --> $DIR/issue-55673.rs:9:8
   |
LL |     T::Baa: std::fmt::Debug,
   |        ^^^ there is a similarly named associated type `Bar` in the trait `Foo`
   |
help: change the associated type name to use `Bar` from `Foo`
   |
LL |     T::Bar: std::fmt::Debug,
   |        ~~~

rustbot · 2023-09-29T03:17:03Z

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

lcnr · 2023-09-29T08:38:56Z

r? compiler

compiler-errors · 2023-09-29T09:58:22Z

kinda swamped/not super free to review this

r? compiler

bors · 2023-10-05T20:36:41Z

☔ The latest upstream changes (presumably #116455) made this pull request unmergeable. Please resolve the merge conflicts.

b-naber

r=me with or without nits addressed.

b-naber · 2023-10-13T11:14:04Z

compiler/rustc_hir_analysis/src/astconv/errors.rs

@@ -102,6 +101,7 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
        &self,
        all_candidates: impl Fn() -> I,
        ty_param_name: &str,
+        ty_param_def_id: Option<LocalDefId>,


nit: can you maybe combine ty_param_name and ty_param_def_id into a new type instead of passing them separately?

b-naber · 2023-10-13T11:14:32Z

compiler/rustc_hir_analysis/src/astconv/mod.rs

@@ -1074,6 +1075,7 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
        &self,
        all_candidates: impl Fn() -> I,
        ty_param_name: impl Display,
+        ty_param_def_id: Option<LocalDefId>,


and use that new type here too?

Fix rust-lang#101351. When an associated type on a type parameter is used, and the type parameter isn't constrained by the correct trait, suggest the appropriate trait bound: ``` error[E0220]: associated type `Associated` not found for `T` --> file.rs:6:15 | 6 | field: T::Associated, | ^^^^^^^^^^ there is a similarly named associated type `Associated` in the trait `Foo` | help: consider restricting type parameter `T` | 5 | struct Generic<T: Foo> { | +++++ ``` When an associated type on a type parameter has a typo, suggest fixing it: ``` error[E0220]: associated type `Baa` not found for `T` --> $DIR/issue-55673.rs:9:8 | LL | T::Baa: std::fmt::Debug, | ^^^ there is a similarly named associated type `Bar` in the trait `Foo` | help: change the associated type name to use `Bar` from `Foo` | LL | T::Bar: std::fmt::Debug, | ~~~ ```

b-naber · 2023-10-13T22:37:23Z

compiler/rustc_middle/src/ty/diagnostics.rs

@@ -25,6 +25,8 @@ impl<'tcx> IntoDiagnosticArg for Ty<'tcx> {
    }
 }

+pub struct TyParam<'a>(pub &'a str, pub Option<DefId>);


ParamTy already exists. TyParamInfo isn't great either, but maybe a little less confusing?

What do you think of TyParamContext?

These values describe the type parameter itself though and not the context it is in, so I don't think TyParamContext is a good name. I would maybe pick TyParamDiagnosticsInfo. You can also just change this back to taking two parameters, it's really not that important to me.

Ok. Removed the last commit to keep the two args instead. I'll come back to this later to reduce the number of args, likely with a new struct and a single argument.

b-naber · 2023-10-16T10:56:08Z

@bors r+ rollup

bors · 2023-10-16T10:56:10Z

📌 Commit 20c622e has been approved by b-naber

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#114157 (Enable triagebot no-merges check) - rust-lang#116257 (Suggest trait bounds for used associated type on type param) - rust-lang#116430 (vendoring in tarball sources) - rust-lang#116709 (Update minifier version to 0.2.3) - rust-lang#116786 (Update my mailmap entry) - rust-lang#116790 (opt-dist: disable unused features for tabled crate) - rust-lang#116802 (Remove `DefiningAnchor::Bubble` from opaque wf check) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116257 - estebank:issue-101351, r=b-naber Suggest trait bounds for used associated type on type param Fix rust-lang#101351. When an associated type on a type parameter is used, and the type parameter isn't constrained by the correct trait, suggest the appropriate trait bound: ``` error[E0220]: associated type `Associated` not found for `T` --> file.rs:6:15 | 6 | field: T::Associated, | ^^^^^^^^^^ there is a similarly named associated type `Associated` in the trait `Foo` | help: consider restricting type parameter `T` | 5 | struct Generic<T: Foo> { | +++++ ``` When an associated type on a type parameter has a typo, suggest fixing it: ``` error[E0220]: associated type `Baa` not found for `T` --> $DIR/issue-55673.rs:9:8 | LL | T::Baa: std::fmt::Debug, | ^^^ there is a similarly named associated type `Bar` in the trait `Foo` | help: change the associated type name to use `Bar` from `Foo` | LL | T::Bar: std::fmt::Debug, | ~~~ ```

rustbot assigned lcnr Sep 29, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2023

estebank force-pushed the issue-101351 branch from fe67e70 to f7b3ba5 Compare September 29, 2023 03:17

This comment was marked as resolved.

Sign in to view

rustbot assigned compiler-errors and unassigned lcnr Sep 29, 2023

rustbot assigned b-naber and unassigned compiler-errors Sep 29, 2023

estebank force-pushed the issue-101351 branch from f7b3ba5 to 0608151 Compare September 29, 2023 15:47

b-naber approved these changes Oct 13, 2023

View reviewed changes

estebank added 2 commits October 13, 2023 19:13

Tweak wording

20c622e

estebank force-pushed the issue-101351 branch from b19e84e to ddfea0d Compare October 13, 2023 20:32

b-naber reviewed Oct 13, 2023

View reviewed changes

estebank force-pushed the issue-101351 branch 3 times, most recently from 2cfe8ed to 20c622e Compare October 15, 2023 22:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2023

matthiaskrgr mentioned this pull request Oct 16, 2023

Rollup of 7 pull requests #116804

Merged

bors merged commit 14663e0 into rust-lang:master Oct 16, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 16, 2023

Veykril mentioned this pull request Oct 17, 2023

Pull upstream master 2023 10 17 ferrocene/ferrocene#54

Merged

estebank deleted the issue-101351 branch November 9, 2023 05:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggest trait bounds for used associated type on type param #116257

Suggest trait bounds for used associated type on type param #116257

estebank commented Sep 29, 2023

rustbot commented Sep 29, 2023

This comment was marked as resolved.

lcnr commented Sep 29, 2023

compiler-errors commented Sep 29, 2023 •

edited

Loading

bors commented Oct 5, 2023

b-naber left a comment

b-naber Oct 13, 2023

estebank Oct 13, 2023

b-naber Oct 13, 2023

b-naber Oct 13, 2023

estebank Oct 13, 2023

b-naber Oct 14, 2023

estebank Oct 15, 2023

b-naber commented Oct 16, 2023

bors commented Oct 16, 2023

Suggest trait bounds for used associated type on type param #116257

Suggest trait bounds for used associated type on type param #116257

Conversation

estebank commented Sep 29, 2023

rustbot commented Sep 29, 2023

This comment was marked as resolved.

lcnr commented Sep 29, 2023

compiler-errors commented Sep 29, 2023 • edited Loading

bors commented Oct 5, 2023

b-naber left a comment

Choose a reason for hiding this comment

b-naber Oct 13, 2023

Choose a reason for hiding this comment

estebank Oct 13, 2023

Choose a reason for hiding this comment

b-naber Oct 13, 2023

Choose a reason for hiding this comment

b-naber Oct 13, 2023

Choose a reason for hiding this comment

estebank Oct 13, 2023

Choose a reason for hiding this comment

b-naber Oct 14, 2023

Choose a reason for hiding this comment

estebank Oct 15, 2023

Choose a reason for hiding this comment

b-naber commented Oct 16, 2023

bors commented Oct 16, 2023

compiler-errors commented Sep 29, 2023 •

edited

Loading