Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_layout, rustc_abi: make sure the types are well-formed #115712

Merged
merged 3 commits into from
Sep 10, 2023
Merged

rustc_layout, rustc_abi: make sure the types are well-formed #115712

merged 3 commits into from
Sep 10, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 9, 2023 •
edited
Loading

Fixes #115676

@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 9, 2023
@RalfJung RalfJung mentioned this pull request Sep 9, 2023
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2023

📌 Commit 3bd8bcb has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2023
@bors
Copy link
Contributor

bors commented Sep 10, 2023

⌛ Testing commit 3bd8bcb with merge 0d0ad42...

@bors
Copy link
Contributor

bors commented Sep 10, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 0d0ad42 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 10, 2023
@bors bors merged commit 0d0ad42 into rust-lang:master Sep 10, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 10, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0d0ad42): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 627.878s -> 629.717s (0.29%)
Artifact size: 317.90 MiB -> 317.90 MiB (0.00%)

@RalfJung RalfJung deleted the wf branch September 11, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@b-naber b-naber

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

rustc_layout(debug) does not complain about nonsense types
7 participants
@RalfJung @rustbot @rust-log-analyzer @compiler-errors @bors @rust-timer @b-naber