Add #[no_coverage] to the test harness's fn main
#111042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Ideally the instrumentor would also be fixed to not emit invalid/confusing mappings. (For example, #97368 managed to fix one problem, but ended up exposing a more subtle problem.) But I think adding |
This comment has been minimized.
This comment has been minimized.
|
@rustbot label +A-code-coverage +A-libtest |
rustbot
added
A-code-coverage
wesleywiser
approved these changes
May 1, 2023
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 1, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#109540 (std docs: edit `PathBuf::set_file_name` example) - rust-lang#110093 (Add 64-bit `time_t` support on 32-bit glibc Linux to `set_times`) - rust-lang#110987 (update wasi_clock_time_api ref.) - rust-lang#111038 (Leave promoteds untainted by errors when borrowck fails) - rust-lang#111042 (Add `#[no_coverage]` to the test harness's `fn main`) - rust-lang#111057 (Make sure the implementation of TcpStream::as_raw_fd is fully inlined) - rust-lang#111065 (Explicitly document how Send and Sync relate to references) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
In the fuchsia build, I'm seeing a new error pop up that I think is caused by this PR: that's truncated a bit, but I also have the full output Details
The test it's trying to compile is https://cs.opensource.google/fuchsia/fuchsia/+/main:src/sys/test_runners/rust/test_data/no-rust-tests/src/lib.rs (an empty file) so it sort of intuitively makes sense how adding Is that something that's obvious to you? I wasn't able to reproduce this for Linux, and something about the upstream-distributed libstd for fuchsia seems to be incompatible with coverage (not sure what that's about, the fuchsia-built toolchain before this PR works fine for coverage). And for some reason |
|
This doesn't ring any bells, unfortunately. My best guess is that some Fuchsia-specific code in the compiler accidentally assumes that every instrumented build contains at least one instrumented function. Now that the test entry point is not instrumented, it's possible for an empty test file to have no instrumented functions, exposing a latent bug in that Fuchsia-specific code. |
|
For example, there might be a loop (explicit or implicit) over all instrumented functions that has a side-effect of properly setting up the profiler runtime for the resulting binary. Now that there are zero instrumented functions, that setup would no longer happen, so the binary ends up in an unlinkable state. |
|
Also related: #102900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two main motivations for adding
#[no_coverage]to the test harness's entry point:llvm-covand result in strange coverage reports.Fixes #110749.