Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linux-raw-sys to 0.3.4 #110518

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Update linux-raw-sys to 0.3.4 #110518

merged 1 commit into from
Apr 25, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Apr 19, 2023 •
edited
Loading

To support LoongArch.

Changes:

Updating errno v0.2.8 -> v0.3.1
Updating is-terminal v0.4.4 -> v0.4.7
Updating linux-raw-sys v0.1.4 -> v0.3.4
Updating rustix v0.36.5 -> v0.37.7
Updating terminal_size v0.2.3 -> v0.2.6
  Adding windows-sys v0.48.0

The changes are generated by:

cargo update -p is-terminal -p terminal_size

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2023

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2023
@heiher heiher mentioned this pull request Apr 19, 2023
Merged
9 tasks
Mark-Simulacrum
Mark-Simulacrum reviewed Apr 19, 2023
View reviewed changes
Cargo.lock Outdated
"windows_i686_msvc 0.42.2",
"windows_x86_64_gnu 0.42.2",
"windows_x86_64_gnullvm 0.42.2",
"windows_x86_64_msvc 0.42.2",
]

[[package]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we / can we also bump this while we're at it? I'm not sure if that's a no-op change but it would be nice to avoid duplicating all these crates in our dependency tree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mark-Simulacrum Could you clarify if the objective is to minimize changes to unrelated dependencies and focus solely on upgrading linux-raw-sys? Would you be able to provide me with some guidance on how to proceed? Thank you. ❤️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these changes generated by cargo update -p is-terminal -p terminal_size without any manual modifications. Should we trust the results generated by cargo? @Mark-Simulacrum

@heiher heiher changed the title Update dependencies Update linux-raw-sys to 0.3.2 Apr 20, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@heiher heiher marked this pull request as draft April 20, 2023 07:48
@heiher heiher marked this pull request as ready for review April 20, 2023 16:23
@heiher heiher changed the title Update linux-raw-sys to 0.3.2 Update linux-raw-sys to 0.3.3 Apr 20, 2023
@heiher
Update dependencies
7aa257f 
To support LoongArch.

Changes:
  Updating errno v0.2.8 -> v0.3.1
  Updating is-terminal v0.4.4 -> v0.4.7
  Updating linux-raw-sys v0.1.4 -> v0.3.4
  Updating rustix v0.36.5 -> v0.37.7
  Updating terminal_size v0.2.3 -> v0.2.6
    Adding windows-sys v0.48.0

The changes are generated by:

  cargo update -p is-terminal -p terminal_size
@bors
Copy link
Contributor

bors commented Apr 23, 2023

☔ The latest upstream changes (presumably #110186) made this pull request unmergeable. Please resolve the merge conflicts.

@heiher heiher changed the title Update linux-raw-sys to 0.3.3 Update linux-raw-sys to 0.3.4 Apr 23, 2023
@heiher
Copy link
Contributor Author

heiher commented Apr 23, 2023

@Mark-Simulacrum After rebasing to #110186, the patch appears to be more concise. Could you please review it again? Thank you.

@heiher heiher requested a review from Mark-Simulacrum April 23, 2023 08:13
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit 7aa257f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
@bors
Copy link
Contributor

bors commented Apr 25, 2023

⌛ Testing commit 7aa257f with merge 666fee2...

@bors
Copy link
Contributor

bors commented Apr 25, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 666fee2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 25, 2023
@bors bors merged commit 666fee2 into rust-lang:master Apr 25, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 25, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (666fee2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.7% [-0.7%, -0.7%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@heiher heiher deleted the update-linux-raw-sys branch April 26, 2023 01:46
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2023
@bors
Auto merge of rust-lang#110519 - loongarch-rs:ci, r=Mark-Simulacrum
cda5bec 
ci: Add support for dist-loongarch64-linux

We are preparing to promote loongarch64-unknown-linux-gnu to Tier 2, and one of the tasks is to add CI support. We are currently in the process of upgrading the dependencies for the build tools, and before this is completed, we would like to request comments. Thanks

#### Progress

- [x] Update linux-raw-sys to 0.3.2 (rust-lang/cargo#11998)
- [x] Update openssl-src to 111.25.3+1.1.1t (rust-lang/cargo#12005)
- [x] bootstrap: Update linux-raw-sys to 0.3.2 (rust-lang#110516)
- [x] Update linux-raw-sys to 0.3.4 (rust-lang#110518)
- [x] Update cargo (rust-lang#110834)
- [x] linux_like: Add missing constants for loongarch64 (rust-lang/libc#3237)
- [x] Release 0.2.143 (rust-lang/libc#3236)
- [x] Update libc to 0.2.144 (rust-lang/cargo#12098)
- [x] Update cargo (rust-lang#111456)

Tier 2 with host tools MCP: rust-lang/compiler-team#518
saethlin pushed a commit to saethlin/miri that referenced this pull request May 26, 2023
@bors
Auto merge of #110519 - loongarch-rs:ci, r=Mark-Simulacrum
be135cd 
ci: Add support for dist-loongarch64-linux

We are preparing to promote loongarch64-unknown-linux-gnu to Tier 2, and one of the tasks is to add CI support. We are currently in the process of upgrading the dependencies for the build tools, and before this is completed, we would like to request comments. Thanks

#### Progress

- [x] Update linux-raw-sys to 0.3.2 (rust-lang/cargo#11998)
- [x] Update openssl-src to 111.25.3+1.1.1t (rust-lang/cargo#12005)
- [x] bootstrap: Update linux-raw-sys to 0.3.2 (rust-lang/rust#110516)
- [x] Update linux-raw-sys to 0.3.4 (rust-lang/rust#110518)
- [x] Update cargo (rust-lang/rust#110834)
- [x] linux_like: Add missing constants for loongarch64 (rust-lang/libc#3237)
- [x] Release 0.2.143 (rust-lang/libc#3236)
- [x] Update libc to 0.2.144 (rust-lang/cargo#12098)
- [x] Update cargo (rust-lang/rust#111456)

Tier 2 with host tools MCP: rust-lang/compiler-team#518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
6 participants
@heiher @rustbot @rust-log-analyzer @bors @Mark-Simulacrum @rust-timer