Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rm const traits in libcore #110393

Merged
merged 15 commits into from
Apr 19, 2023
Merged

Rm const traits in libcore #110393

merged 15 commits into from
Apr 19, 2023

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Apr 16, 2023 •
edited by RalfJung
Loading

See zulip thread and #110395

  • Bless ui tests
  • Re constify some unstable functions with workarounds if they are needed

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@fee1-dead
Copy link
Member Author

cc @rust-lang/wg-const-eval

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Apr 16, 2023

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned scottmcm Apr 16, 2023
@fee1-dead fee1-dead mentioned this pull request Apr 16, 2023
Closed
4 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Apr 16, 2023

@bors r+ p=1 bitrotty

@bors
Copy link
Contributor

bors commented Apr 16, 2023

📌 Commit 4c6ddc0 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2023
@saethlin saethlin mentioned this pull request Sep 3, 2023
Merged
@dtolnay dtolnay mentioned this pull request Sep 17, 2023
Merged
@dtolnay dtolnay mentioned this pull request Sep 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2023
@bors
Auto merge of rust-lang#116240 - dtolnay:constdiscriminant, r=thomcc
06f9d37 
Const stabilize mem::discriminant

Tracking issue: rust-lang#69821.

This PR is a rebase of rust-lang#103893 to resolve conflicts in library/core/src/lib.rs (against rust-lang#102470 and rust-lang#110393).
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2023
@bors
Auto merge of rust-lang#116240 - dtolnay:constdiscriminant, r=thomcc
7cc36de 
Const stabilize mem::discriminant

Tracking issue: rust-lang#69821.

This PR is a rebase of rust-lang#103893 to resolve conflicts in library/core/src/lib.rs (against rust-lang#102470 and rust-lang#110393).
@jruderman jruderman mentioned this pull request Nov 5, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 20, 2023
Closed
This was referenced Nov 23, 2023
Closed
Open
@fee1-dead fee1-dead mentioned this pull request Dec 12, 2023
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 27, 2024
Closed
@dtolnay dtolnay mentioned this pull request Jun 25, 2024
Closed
3 tasks
@dtolnay dtolnay mentioned this pull request Jul 17, 2024
Closed
This was referenced Sep 7, 2024
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
@rinarakaki rinarakaki mentioned this pull request Sep 11, 2024
Open
3 tasks
jackh726
jackh726 reviewed Sep 14, 2024
View reviewed changes
tests/ui/const-generics/generic_const_exprs/unify-op-with-fn-call.rs
@@ -1,3 +1,5 @@
// known-bug: #110395
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the necro:

This is a bad annotation. This test no longer tests what it was intended to. Also, #110395 isn't a bug...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 left review comments

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.